Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device-patchcoord container in osd note/warning in code - still relevant ? #1339

Open
nyue opened this issue Aug 22, 2024 · 1 comment
Open

Comments

@nyue
Copy link
Contributor

nyue commented Aug 22, 2024

Is the following comment still something we need to take note of ?

https://github.com/PixarAnimationStudios/OpenSubdiv/blob/release/examples/glEvalLimit/glEvalLimit.cpp#L258

I am unsure what it is referring to.

@davidgyu
Copy link
Member

IIRC the motivation for that comment is that an array of 20-byte elements (5-ints per element) is going to lead to inefficient memory access. This will be true regardless of whether the data fetch is by the Input Assembler from a vertex buffer or via direct access from a GPU buffer.

I think it would be okay to remove that comment, and we will take that into account as we're updating the example code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants