Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for MaterialX namespaces declared in stdlibs #1631

Merged

Conversation

vlasovi
Copy link
Contributor

@vlasovi vlasovi commented Sep 24, 2021

Description of Change(s)

  • Make sure MtlxPlugin properly merges all stdlib files into a single library by calling 'importLibarary', thus preserving namespaces among other attributes
  • Make sure HdStorm properly reconstructs MaterialX namespace name when assembling MaterialX document from HdMaterialNetwork2

Fixes Issue(s)

@jilliene
Copy link

Filed as internal issue #USD-6927

@spiffmon
Copy link
Member

Thanks, @vlasovi - it looks like we do not have a signed CLA from you, which we would need to be able to consider this request. Could you submit one?

@vlasovi
Copy link
Contributor Author

vlasovi commented Oct 1, 2021

@spiffmon I'm a developer at Autodesk and I believe that Autodesk has already signed a corporate CLA with you. Do you want me to sign an individual contributor CLA as well?

@spiffmon
Copy link
Member

spiffmon commented Oct 1, 2021

Ah, in that case, please contact Gordon and/or Ian to get you added to the list of approved Autodesk contributors - thanks, @vlasovi !

@vlasovi
Copy link
Contributor Author

vlasovi commented Oct 27, 2021

@spiffmon, I believe that Gordon added me to the CLA.

@spiffmon
Copy link
Member

Yes, you're all set on the CLA front, @vlasovi . While it's not yet possible for you to add an imaging test, would you please add a test in usdMtlx that verifies the handling of namespaces, and also update the overview.dox to remove namespaces from the list of unsupported features?

Thanks!

@vlasovi
Copy link
Contributor Author

vlasovi commented Nov 1, 2021

@spiffmon I updated the PR with the requested changes.

@pixar-oss pixar-oss merged commit c958acb into PixarAnimationStudios:dev Feb 25, 2022
@AdamFelt AdamFelt deleted the ogs/mtlx_namespaces branch October 11, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants