[HGI] Cleanup of vertex bindings, split off HgiMetal step functions #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7382 |
1 task
creijon
force-pushed
the
jon/dev/graphics_command
branch
3 times, most recently
from
cba8506
to
4f0596c
Compare
creijon
force-pushed
the
jon/dev/graphics_command
branch
from
4f0596c
to
2ba52f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
General code cleanup around the HgiMetal implementation of graphicsCmds. The vertex buffer bindings were being passed around as two parallel arrays of buffer handles and byte offsets with a 'firstBinding' parameter too. Moved this to a new struct
HgiVertexBufferBinding.This allows the
HdStPipelineDrawBatchto be cleaned up too.There was a lot of logic around the calculation and setting of the vertex buffer step functions in
HgiMetalGraphicsCmdthis has been split out to a separate classHgiMetalStepFunctionswhich can be used by other parts of the engine.Fixes Issue(s)