APPLE: Texture and buffer writability in Metal/HGI along with settings where appropriate #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7640 |
creijon
suggested changes
Sep 20, 2022
pxr/imaging/hgi/resourceBindings.h
Outdated
| @@ -130,6 +131,7 @@ struct HgiTextureBindDesc | |||
| HgiBindResourceType resourceType; | |||
| uint32_t bindingIndex; | |||
| HgiShaderStage stageUsage; | |||
| bool readOnly; | |||
There was a problem hiding this comment.
In shadersection we use _writable while here we use readOnly. For consistency shouldn't they be the same?
creijon
suggested changes
Sep 20, 2022
There was a problem hiding this comment.
Make sure that the readOnly flag is initialised in every instance of the HgiBufferBindDesc creation. There's a few instances in flatNormals.cpp, quadrangulate.cpp, resourceBinder.cpp, smoothNormals.cpp, subdivision.cpp, boundingBoxTask.cpp, that need to be covered.
Also the comparator in resourceBindings.cpp needs to include a test for the flag.
slingthor
force-pushed
the
thor/dev/writability
branch
from
f61c219
to
e82478d
Compare
slingthor
force-pushed
the
thor/dev/writability
branch
from
e82478d
to
f5eea54
Compare
|
PR updated! Will be sharing some metrics on MacOS as well |
creijon
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Allows HGI to define readonly buffers and textures
Allow HGIMetal to consume readonly buffers and textures
Take advantage of that in the resource binder and as well in hdx where we manually set up resources
Sets buffers we don't index into to live in constant space, and pass them as const reference instead of as a pointer in device space on Metal