[gf] make vec*.h use GfSqrt instead of sqrt #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7707 |
sunyab
requested changes
Nov 4, 2022
with gcc, at least, this avoids using a double for vec3f::GetLength, which avoids a compiler warning when using -Wconversion
pmolodo
force-pushed
the
pr/vec3f_sqrt
branch
from
29eadd3
to
180c8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
with gcc, at least, this avoids using a double for vec3f::GetLength, which avoids a compiler warning when using -Wconversion
Fixes Issue(s)
warning when using -Wconversion flag on gcc
I have submitted a signed Contributor License Agreement