Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost hash usage with TfHash in pxr/usd/usdGeom #2190

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jan 23, 2023

Description of Change(s)

Requires: #2173
To remove the dependency of pxr/usd/usdGeom on boost's hashing functions

  • Replaces usage of boost::hash_combine and boost::hash with TfHash
  • Add TfHashAppend overloads and update hash_value to use this via TfHash
  • Add unit tests for hashing of UsdGeom.Primvar

Fixes Issue(s)

-#2172 (more PRs forthcoming)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc closed this Jan 23, 2023
@nvmkuruc nvmkuruc reopened this Jan 23, 2023
@nvmkuruc nvmkuruc changed the base branch from release to dev January 23, 2023 17:48
@nvmkuruc nvmkuruc force-pushed the usdgeomhash branch 3 times, most recently from d9991f6 to 0c39b7c Compare January 26, 2023 23:01
@sunyab
Copy link
Contributor

sunyab commented Jan 27, 2023

Filed as internal issue #USD-7910

@pixar-oss pixar-oss merged commit 8a43c77 into PixarAnimationStudios:dev Apr 3, 2023
@nvmkuruc nvmkuruc deleted the usdgeomhash branch December 29, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants