Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost hash usage with TfHash in pxr/usd/usdSkel #2191

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jan 23, 2023

Description of Change(s)

Requires: #2173
To remove the dependency of pxr/usd/usdSkel on boost's hashing functions

  • Add python bindings for __hash__ to UsdSkelSkeletonQuery
  • Add __hash__ test coverage for UsdSkelSkeletonQuery
  • Replaces usage of boost::hash_combine with TfHash::Combine

Fixes Issue(s)

-#2172 (more PRs forthcoming)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc changed the title Usdskelhash Replace boost hash usage with TfHash in pxr/usd/usdSkel Jan 23, 2023
@nvmkuruc nvmkuruc force-pushed the usdskelhash branch 5 times, most recently from 5b18e5c to f590c6b Compare January 26, 2023 22:59
@sunyab
Copy link
Contributor

sunyab commented Jan 27, 2023

Filed as internal issue #USD-7911

@pixar-oss pixar-oss merged commit 5afdcec into PixarAnimationStudios:dev Apr 3, 2023
@nvmkuruc nvmkuruc deleted the usdskelhash branch December 29, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants