Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] iOS devices don't receive audio from other clients #279

Open
Ago251 opened this issue Oct 26, 2023 · 5 comments
Open

[bug] iOS devices don't receive audio from other clients #279

Ago251 opened this issue Oct 26, 2023 · 5 comments

Comments

@Ago251
Copy link

Ago251 commented Oct 26, 2023

Context

I upgraded the Dissonance version from 8.3.1 to 9.0.3 for fix this bug for iOS. The problem has been resolved, but ios devices don't receive sound from other clients. I can detect that a client is speaking, but the amplitude is consistently zero. I also tried a previous build that was loaded on TestFlight with version 8.3.1, and it worked as expected."

Expected behaviour

I expect to receive sound from other clients.

Actual behaviour

With iOS device can send my voice but can't receive voice of others.

Steps to Reproduce

  1. Enter to a chat voice with iOS device

Your Environment

Include as many relevant details about the environment you experienced the bug in

  • Dissonance version used: 9.0.3

  • Unity version: 2021.3.1f1

  • Editor Operating System and version: macOS Ventura (13.6)

  • Build Settings: iOS development and development build

@Ago251 Ago251 changed the title [bug] iOS device don't receive audio [bug] iOS device don't receive audio from other clients Oct 26, 2023
@Ago251 Ago251 changed the title [bug] iOS device don't receive audio from other clients [bug] iOS devices don't receive audio from other clients Oct 26, 2023
@martindevans
Copy link
Member

There's a known issue in 9.0.3 (which I already have a prototype fix for) which sounds similar to this.

Could you try this to see if you are affected by the issue:

  1. In Assets/Plugins/Dissonance/Core/DissonanceCommsImpl.cs find private bool MuteAllRemoteVoices
  2. Change it to public bool MuteAllRemoteVoices
  3. In a separate script, log out FindObjectOfType<DissonanceComms>().MuteAllRemoteVoices every frame

If that is logging out true you're probably affected by that issue. I can send you the prototype fix to test out in that case.

@Ago251
Copy link
Author

Ago251 commented Oct 26, 2023

MuteAllRemoteVoices is true. If you can send me the prototype so I can try it

@martindevans
Copy link
Member

Thanks for checking that. In the same file as before find CoResumePlayback and replace the entire method with this: https://gist.github.com/martindevans/6fbeb64df5d4e52d04af13a99fb3237e

@Ago251
Copy link
Author

Ago251 commented Oct 26, 2023

It is works, thank you!

@martindevans
Copy link
Member

Excellent! Thanks for confirming that. This fix will be included in the next Dissonance update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants