Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having an Issue where colours are all the same, so I an unable to see when an item is highlighted #9

Open
Eoin-McMahon opened this issue Apr 7, 2022 · 10 comments

Comments

@Eoin-McMahon
Copy link

Just installed this and I notice that on my PC all the colours are white. Text, non highlighted items and highlighted items including borders.
so i am unable to see when i have a card highlighted.

It would be nice if you could add a config file under .config/kabmat/
where we could specify specific colours for our kabmat install.
This would also allow the community to create colour files for different popualr colour schemes i.e gruvbox, dracula etc.

keybindings and other things could also be added to the config 😊

@PlankCipher
Copy link
Owner

I actually had this idea in mind all along, and designed the code so that I can add it later easily. Thanks for bringing this to my attention. Very sorry for the late response.

@PlankCipher
Copy link
Owner

For now, you could change the colorscheme of your terminal as a temporary solution.

@rickyelopez
Copy link

This is happening for me as well. What changes do I need to make to my colorscheme for kabmat to show different colors?

@PlankCipher
Copy link
Owner

PlankCipher commented Apr 18, 2022

@rickyelopez, you could simply just use any popular colorscheme for your terminal, e.g. nord, gruvbox, etc. If you want more details, here are the colors that kabmat uses from your terminal's colorscheme.

Black (for foreground of text on backgrounds different than that of the terminal): indexed 0 in colorscheme colors list.
White (to make things standout, e.g. statusline background, highlighted border): indexed 7.
Blue (for background of mode indicator in statusline): indexed 4.

@dhax
Copy link

dhax commented Apr 19, 2022

also tried a couple colorschemes with merely noticable differences for the selected items. I need to change White to something 'non-white' to actually see the selection. Maybe white (7) is not the right choice for e.g. highlighted borders?

@Eoin-McMahon
Copy link
Author

ah it was completely white for me when I was using ssh to connect to the pc with kabmat installed. when running locally I do get colours. although the difference between highlighted and non highlighted is still quite difficult to see, i am using gruvbox btw.

@rickyelopez
Copy link

Hmmm strange @PlankCipher, I'm using a base16-shell color scheme:
image

@PlankCipher
Copy link
Owner

PlankCipher commented Apr 20, 2022

Maybe white (7) is not the right choice for e.g. highlighted borders?

Actually yeah, maybe it isn't the right color to make some things stand out.

I think by default, the normal foreground of text in terminal is the bright white color (15th in colorscheme) and in most colorschemes the white color used by kabmat to highlight stuff is just slightly darker than that bright white foreground, so it is difficult to see as @Eoin-McMahon pointed out. The reason I didn't notice this problem is because I already have a brighter white than the usual one in my gruvbox theme.

Anyway, I think this will be resolved with the next release introducing the config file. Should be out soon.

@dhax
Copy link

dhax commented Jul 4, 2022

no pressure here, soon is a very objective thing... anyway, it helps to not close an issue until it's actually closed ;)

@PlankCipher
Copy link
Owner

Reopening this until implemented/fixed.

@PlankCipher PlankCipher reopened this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants