You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
csp uses a relatively old financial industry format standard, we should consider adopting something more conventional. Noted quirks:
spaces around parentheses, bracket, etc ( x + ( y + z ) ), [ 0 ] [ 1 ]
spaces around ->, e.g. pointer -> attr
spaces on both sides of *, e.g. Thing * th
The first two of these are quite unconventional imo. Additionally, the first tends to cause a habit to form with spaces to be put around parenthesis outside of C++. A quick scan of the documentation will reveal a concerted effort to remove ( spaces inside parens ) in plain english text, put there originally by force of habit.
Autoformatting is great when you just let it do its thing, but it is also very noisy to uplift a repo to be autoformatted, and so we can discuss various pros and cons and perhaps let our C++ contributors do a bit of format-preference-bikeshedding.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
csp
uses a relatively old financial industry format standard, we should consider adopting something more conventional. Noted quirks:( x + ( y + z ) )
,[ 0 ] [ 1 ]
->
, e.g.pointer -> attr
*
, e.g.Thing * th
The first two of these are quite unconventional imo. Additionally, the first tends to cause a habit to form with spaces to be put around parenthesis outside of C++. A quick scan of the documentation will reveal a concerted effort to remove ( spaces inside parens ) in plain english text, put there originally by force of habit.
Autoformatting is great when you just let it do its thing, but it is also very noisy to uplift a repo to be autoformatted, and so we can discuss various pros and cons and perhaps let our C++ contributors do a bit of format-preference-bikeshedding.
Beta Was this translation helpful? Give feedback.
All reactions