Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation 8 DLC Pokedexes don't line up between VersionGroup and Pokedex #947

Closed
TonyCollett opened this issue Nov 1, 2023 · 3 comments

Comments

@TonyCollett
Copy link

TonyCollett commented Nov 1, 2023

There might be a good reason for this, but Generation 8 doesn't match other Generation Version Groups

Starting with Generation 8:
api/v2/generation/8 contains the following Version Groups:
sword-shield
the-isle-of-armor
the-crown-tundra

api/v2/version-group/sword-shield contains the following Pokedexes:
galar
isle-of-armor
crown-tundra

Both api/v2/version-group/the-isle-of-armor and api/v2/version-group/the-crown-tundra contains no Pokedex

If we look at Generation 9:
api/v2/generation/9 contains the following Version Groups:
scarlet-violet
the-teal-mask
the-indigo-disk

api/v2/version-group/scarlet-violet contains the following Pokedex
paldea

api/v2/version-group/the-teal-mask contains the following Pokedex
kitakami

api/v2/version-group/the-indigo-disk contains the following Pokedex
indigo-disk
(This Pokedex is not yet released but is already classified correctly in it's own Pokedex)

I believe that the Pokedexes for DLC of Generation 8 Sword and Shield (Isle of Armor and Crown Tundra) are incorrectly labelled under Sword-Shield and should be reclassified into their correct Version Group

@Naramsim
Copy link
Member

Naramsim commented Nov 1, 2023

You're probably right! That would require us to change all of a series of CSV files.

We had a contributor that had a handy script for doing it

@TonyCollett
Copy link
Author

I don't know the intricacies of this project (yet) and I haven't had a chance to clone and create a test branch, but isn't it as simple as updating the CSV: pokedex_version_groups.csv
Row 29: Remains the same
Row 30: where pokedex_id=28, version_group_id becomes 21 (the-isle-of-armor)
Row 31: where pokedex_id=29, version_group_id becomes 22 (the-crown-tundra)

@TonyCollett
Copy link
Author

@Naramsim This can be closed with #998, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants