Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more colors #2547

Closed
Lunik opened this issue Aug 3, 2016 · 14 comments
Closed

No more colors #2547

Lunik opened this issue Aug 3, 2016 · 14 comments

Comments

@Lunik
Copy link

Lunik commented Aug 3, 2016

Expected Behavior

Logs should be in color

Actual Behavior

Only white logs

Steps to Reproduce

Commit: b2983f7

Other Information

OS: Ubuntu
Git Commit: b2983f7
Python Version: Python 2.7.9

@Kujawadl
Copy link

Kujawadl commented Aug 3, 2016

This is from #2173.

I may be wrong, but I believe this is because the logs are changing to Sockets.IO, and you should be getting them in the web ui from now on.

That being said, I'm still not getting any logs in the web ui :/

Only reason I mention that is because I don't think color is necessary in the logs if they're actually being displayed in the web interface like they should be.

@Lunik
Copy link
Author

Lunik commented Aug 3, 2016

I don't use webUI logs because they don't work lol >.>
But I miss the colors in the console 😭

@Kafkamorph
Copy link

w/e, it looks like shit now.

@Kujawadl
Copy link

Kujawadl commented Aug 3, 2016

#2540 It looks like there are some problems with the bots anyway, so it may be that the webUI logs work, but the bot's just not doing anything.

idk about anyone else, but for me it's just walking around, but none of the distance actually gets recorded (e.g. 10min running, close it out and it says 0.0km walked).

@SpencerCarstens
Copy link

@Lunik Yea, I couldn't figure out the server either, but unsure if it's due to the API being borked or not.

@Vvkmnn
Copy link

Vvkmnn commented Aug 3, 2016

Same here on macOS 10.11.6 running commit b2983f7.

There's more information about how to setup the new bot config and websocket in #2173, but I can't figure it out at the moment.

This seems like an unnecessary complication; I didn't even know we had a Web UI until a few days ago, and I loved the console log. Why forcibly merge the two?

Anyone interested in the old setup should run the following code to revert back to the commit right before this one. I intend on using this until things sort themselves out:

git reset --hard 02d9102

Though it seems like we've got much bigger problems affecting why the logs aren't populating: #2540

@Kujawadl
Copy link

Kujawadl commented Aug 3, 2016

With the server config, I'm using nginx:

config.json

...
  "websocket": {
    "start_embedded_server": true,
    "server_url": "localhost:8080",
    "remote_control": true
  },
...

/etc/nginx/sites-available/default

...
server {
  listen 80;

  root /[wherever]/PokemonGo-Bot/web;
  index index.html index.htm

  location / {
    try_files $uri $uri/ /index.html =404;
  }

  location /socket.io/ {
    proxy_pass http://localhost:8080;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
  }
}
...

I can confirm that the webUI successfully connects to sockets.io, but again, the bot isn't doing anything that would generate a log, so I can't confirm that the logs are being passed correctly.

The reason I'm excited for this to work is that it brings with it the ability to control the bot from the web. Transfer/evolve pokemon, set a destination, etc... So it may not be the best right now, but don't completely give up on it either. There's a lot of potential.

@TCB13
Copy link

TCB13 commented Aug 4, 2016

@Vvkmnn I agree with you, this Web UI should be optional. I really like the simplicity of just running the bot from a command line specifying a config file. The Web UI will bring more complexity over here / issues to reboot the bot etc...

@lt-kraken
Copy link

I'm hoping they are bringing the colorized logging back :)

@SpencerCarstens
Copy link

Was this ever really flushed out or is it half baked still? I can't quite get everything to line up as it should.

@Vvkmnn
Copy link

Vvkmnn commented Aug 7, 2016

@Kujawadl I borrowed your config, but I'm still getting a 404 at that address. Am I missing a parameter?

@Kujawadl
Copy link

Kujawadl commented Aug 7, 2016

@Vvkmnn Can you send me what commit you're on (both the bot and the web project), your config.json, userdata.json, and /etc/nginx/sites-available/default?

@ph3l1x
Copy link

ph3l1x commented Aug 7, 2016

How do we use this cell works file? Are there plans of returning the output back the way it was? I liked to just look at the return from the bot and see what it was doing etc.. Its way to hard to read now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants