-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransferPokemon keep_best_release #2790
Comments
same to me |
You have the issue only with vaporeon ? |
I have 3 Pinsirs, 2 Starmies and 2 Vaporeons with above 1600 cp.
|
I have this issue only with Vaporeon because it's the only one I got twice (with more than 1200CP and 0.9IV). But I guess this will be the same for every pokemon you have twice (or more). The issue comes from the config I think, what's your release configs ? |
Here it is:
` |
I have the same issue only with this: on every move config: "any": {"keep_best_cp": 1, "keep_best_iv": 3, "release_below_cp": 100, "release_below_iv": 0.75, "logic": "or"}, |
I guess keep_best and release_below don't go together ... |
It worked with the old api. Something was changed we have to figure out what exactly |
Well, it's "working", we got our pokemons like we want. It's just the logging ... since everything changed. |
It might have been the same before, it is just weird case looking at my drowzees: |
yeah, just logging that make my console dirty :) |
I get this Keeping best flood too. I tried to remove all the "if best_pokemons and all_pokemons:" and it worked (no more logs) but the pokemon transfer doesn't worked anymore...I have to try this again |
Fixed in #3223 |
Expected Behavior
TransferPokemon should not call or log non stop.
2016-08-07 15:20:25,217 [TransferPokemon] [INFO] [keep_best_release] Keeping best 4 Zubat, based on cp and iv
2016-08-07 15:20:25,218 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Zubat (CP 10/IV 0.71) based on rule: CP < 225 OR IV < 0.8
2016-08-07 15:20:25,640 [TransferPokemon] [INFO] [pokemon_release] Exchanged Zubat [CP 10] [IV 0.71] for candy.
Check keep_best_release then release extras.
Actual Behavior
2016-08-07 15:20:25,217 [TransferPokemon] [INFO] [keep_best_release] Keeping best 4 Zubat, based on cp and iv
2016-08-07 15:20:25,218 [TransferPokemon] [INFO] [future_pokemon_release] Releasing Zubat (CP 10/IV 0.71) based on rule: CP < 225 OR IV < 0.8
2016-08-07 15:20:25,640 [TransferPokemon] [INFO] [pokemon_release] Exchanged Zubat [CP 10] [IV 0.71] for candy.
2016-08-07 15:20:28,945 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
2016-08-07 15:20:38,960 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
2016-08-07 15:20:49,143 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
2016-08-07 15:20:49,966 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
2016-08-07 15:20:50,698 [ SpinFort] [INFO] [spun_pokestop] Spun pokestop п═я┐п╦пҐп╦ 2. Experience awarded: 50. Items awarded: {u'Razz Berry': 1, u'Pokeball': 1, u'Super Potion': 1}
2016-08-07 15:21:01,985 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
2016-08-07 15:21:02,548 [RecycleItems] [INFO] [item_discarded] Discarded 1x Super Potion (maximum 0).
2016-08-07 15:21:12,615 [TransferPokemon] [INFO] [keep_best_release] Keeping best 3 Drowzee, based on cp and iv
This problem seems to happen with Drowzee either this event is the first one that apear and it keep getting logged or there is something else going on.
As you can see it is only checking keep_best_release and not releasing anything
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)
The text was updated successfully, but these errors were encountered: