Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log TransferPokemon with keep_best_iv if rules don't match any #3064

Closed
DiegoRBaquero opened this issue Aug 8, 2016 · 2 comments
Closed

Comments

@DiegoRBaquero
Copy link

Expected Behavior

Not logging about 3rd+ Pokemon based on IV because none should be released based on rules.

Actual Behavior

Logging about releasing 3rd+ Pokemon when they don't match release rules:

[TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Eevee, based on iv
[TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Horsea, based on iv

This keeps showing up every 4 lines.

It does release others normally based on rules:

[TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Eevee, based on iv
[TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Pidgey, based on iv
[TransferPokemon] [INFO] [future_pokemon_release] Releasing Pidgey (CP 284/IV 0.38) based on rule: CP < 100 OR IV < 0.8
[TransferPokemon] [INFO] [pokemon_release] Exchanged Pidgey [CP 284] [IV 0.38] for candy.

Steps to Reproduce

Having 3+ Pokemons that shouldn't be released and this config:
"release": {"any": {"release_below_cp": 100, "release_below_iv": 0.8, "logic": "or", "keep_best_iv": 2} }

Other Information

OS: Mac OS
Git Commit: 5b3fe3d
Python Version: 2.7.12

@elicwhite
Copy link
Contributor

Fixed in #3223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@elicwhite @DiegoRBaquero and others