Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on '[pokemon_fled] Rattata fled'? #3105

Closed
leadboots5 opened this issue Aug 8, 2016 · 3 comments
Closed

Thoughts on '[pokemon_fled] Rattata fled'? #3105

leadboots5 opened this issue Aug 8, 2016 · 3 comments

Comments

@leadboots5
Copy link
Contributor

In the current code when a pokemon breaks out of the ball you get a line like this:
[pokemon_fled] Rattata fled

To me that sounds a lot like they ran away because that is what it means to flee... Do others agree/disagree?
I can submit a change for something else like based on opinions:
[pokemon_breakout] Rattata broke out.

For reference when they disappear you get it:
[pokemon_vanished] Rattata vanished

Thank You.

@jrjhealey
Copy link

Fled means it actually ran away. If it simply failed ton catch the bottom should (or at least used) to say so. And it would attempt to re-catch.

If it flees there's nothing you can do.

@leadboots5
Copy link
Contributor Author

This has been merged in by someone else. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@leadboots5 @jrjhealey and others