Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Output Error] Pokemon fled and then caught #3152

Closed
nicholasjohn opened this issue Aug 8, 2016 · 5 comments
Closed

[Output Error] Pokemon fled and then caught #3152

nicholasjohn opened this issue Aug 8, 2016 · 5 comments

Comments

@nicholasjohn
Copy link

Expected Behaviour

EITHER:

  1. When a Pokemon flees, to continue to other tasks.
  2. When a ball fails, Pokemon either flees or stays to allow another ball to be thrown

Actual Behaviour

When ball fails due to low chance rate, Pokemon fled is output. However, another ball is then thrown, and Captured Pokemon! is output.

Steps to Reproduce

See output below:

[PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Spearow appeared! [CP 247] [Potential 0.4] [S/A/D 8/6/4]
[PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 38.66 (24 left)
[PokemonCatchWorker] [INFO] [pokemon_fled] Spearow fled.
[PokemonCatchWorker] [INFO] [threw_pokeball] Used Pokeball, with chance 38.66 (23 left)
[PokemonCatchWorker] [INFO] [pokemon_caught] Captured Spearow! [CP 247] [Potential 0.4] [8/6/4] [+420 exp]

Other Information

OS: OSX El Capitan
Git Commit: 5b3fe3d
Python Version: Python 2.7.12

@nicholasjohn nicholasjohn changed the title [OUTPUT BUG?] Pokemon fled and then caught [Output Error] Pokemon fled and then caught Aug 8, 2016
@iruy
Copy link

iruy commented Aug 8, 2016

Fled doesn't mean Vanished, but just that the pokemon escaped the ball

@g2384
Copy link

g2384 commented Aug 8, 2016

By fled it means broke free. I don't understand this update. it's confusing

@leadboots5
Copy link
Contributor

leadboots5 commented Aug 8, 2016

This has already been fixed:
#3129

close please.

@g2384
Copy link

g2384 commented Aug 8, 2016

Update: By escaped it means broke free. I don't understand this update either. It's still confusing.

Can we just say failed, try again?

@nicholasjohn
Copy link
Author

Closing. #3129 does indeed fix the wording issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants