Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egg Hatching logs do not truncate IV #3381

Closed
bstpierr opened this issue Aug 10, 2016 · 3 comments
Closed

Egg Hatching logs do not truncate IV #3381

bstpierr opened this issue Aug 10, 2016 · 3 comments

Comments

@bstpierr
Copy link
Contributor

Expected Behavior

Egg hatching log output should match the rest of the log output.

Actual Behavior

Log output does not match the rest of the bot's output.

[23:27:12] Egg hatched with a Magmar (CP 1244 - IV 10/14/11 0.777777777778), 1000 exp, 2780 stardust and 27 candies.

compared to the release output:

[23:27:14] Exchanged Magmar [CP 1244] [IV 0.78] for candy.

I'd expect the same MonName [CP ###] [IV #.##] output.

It might be worth adding this sort of string output formatting to the utils class.

@leadboots5
Copy link
Contributor

Looks like it just needs to be changed over yet to using the inventory class(unless there is a reason this should be in utils instead of inventory?). Looks like transferring was just moved over to it:
8b5af8d

@bstpierr
Copy link
Contributor Author

Didn't realize the Inventory class was now in. That sounds perfect for this.

@mjmadsen
Copy link
Contributor

Seems resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants