Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname config, favorite still get renamed. #4009

Closed
avexus opened this issue Aug 15, 2016 · 4 comments
Closed

Nickname config, favorite still get renamed. #4009

avexus opened this issue Aug 15, 2016 · 4 comments

Comments

@avexus
Copy link

avexus commented Aug 15, 2016

Expected Behavior

when you set "dont_nickname_favorite": true
favorite should not be nicknamed.
I think i posted it some time ago, but could not find it.

Actual Behavior

They still get renamed.

Your config.json (remove your credentials and any other private info)

{
    "type": "NicknamePokemon",
    "config": {
        "nickname_template": "{ivcp_pct2}%{iv_ads}"
    },
    "enabled": true,
    "dont_nickname_favorite": true,
    "good_attack_threshold": 0.7
}
@BriceSD
Copy link
Contributor

BriceSD commented Aug 15, 2016

@avexus Need more infos.

Other Information

OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

@avexus
Copy link
Author

avexus commented Aug 15, 2016

@BriceSD It's like this. I have several pokemons marked as favorite. I gave them special names. But when I run the script, they all gets renamed after the "nickname_template".
If I set
"dont_nickname_favorite": true,
They should not be renamed.

@BriceSD
Copy link
Contributor

BriceSD commented Aug 15, 2016

OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

@avexus
Copy link
Author

avexus commented Aug 15, 2016

It seems fixed now.

@avexus avexus closed this as completed Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants