Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange spam on screen on newlatest dev version. #4602

Closed
takenek opened this issue Aug 23, 2016 · 9 comments
Closed

Strange spam on screen on newlatest dev version. #4602

takenek opened this issue Aug 23, 2016 · 9 comments

Comments

@takenek
Copy link

takenek commented Aug 23, 2016

Before you create an Issue, please check the following:

  1. Have you validated that your config.json is valid JSON? Use http://jsonlint.com/ to check.
    YES

  2. Have you searched our issue tracker to see if the issue already exists? If so, comment on that issue instead rather than creating a new issue.
    YES

  3. Are you running on the master branch? We work on the dev branch and then add that functionality to master when it is stable. Your issue may be fixed on dev and there is no need for this issue, just wait and it will eventually be merged to master.
    dev

  4. All Issue sections MUST be completed to help us determine the actual problem and find its cause
    I know

    Expected Behavior

    No spam on screen

Actual Behavior

Spam on screen

Your FULL config.json (remove your username, password, gmapkey and any other private info)

I think this is not need it.

Output when issue occurred

2016-08-23 07:45:36,925 [PokemonGoBot] [INFO] [login_started] Login procedure started.
pgomapcatch/all/catchable/74 0 34.0118999401,-118.496021687,5132752274995820157
pgomapcatch/all/catchable/104 0 34.0118888695,-118.495747987,8408328944486764381
pgomapcatch/all/catchable/17 0 37.8060337161,-122.431904656,1253898590250416861
pgomapcatch/all/catchable/19 0 37.8062315839,-122.431019863,14493214305910525
pgomapcatch/all/catchable/19 0 37.8062442659,-122.43146226,7038093087127419933
pgomapcatch/all/catchable/20 0 37.8064076317,-122.430931383,18421731353777692429
pgomapcatch/all/catchable/16 0 37.8060010806,-122.431285302,7627845837456767773
2016-08-23 07:45:38,375 [PokemonGoBot] [INFO] [login_successful] Login successful.
2016-08-23 07:45:38,375 [PokemonGoBot] [INFO] Found encrypt.so! Platform: linux2 encrypt.so directory: /home/login/PokemonGo-Bot
2016-08-23 07:45:38,375 [PokemonGoBot] [INFO]
pgomapcatch/all/catchable/81 0 40.7585141896,-73.9703763988,6183672017631188909
2016-08-23 07:45:39,128 [PokemonGoBot] [INFO] Level: 1 (Next Level: 400 XP) (Total: 600 XP)
pgomapcatch/all/catchable/17 0 37.8060337161,-122.431904656,1253898590250416861
pgomapcatch/all/catchable/19 0 37.8062315839,-122.431019863,14493214305910525
pgomapcatch/all/catchable/19 0 37.8062442659,-122.43146226,7038093087127419933
pgomapcatch/all/catchable/20 0 37.8064076317,-122.430931383,18421731353777692429
pgomapcatch/all/catchable/16 0 37.8060010806,-122.431285302,7627845837456767773
pgomapcatch/all/catchable/54 0 25.1364616874,121.506711165,16163643224141897629
pgomapcatch/all/catchable/54 0 25.1367561371,121.505461956,15220322102140149069
pgomapcatch/all/catchable/72 0 -33.8586657365,151.210198631,15187119875658492173
pgomapcatch/all/catchable/17 0 37.8060337161,-122.431904656,1253898590250416861

Steps to Reproduce

Run a bot on dev branch

Other Information

OS: Debian SiD
Branch: dev
Git Commit: 9147815
Python Version: Python 2.7.9

Best Regards
TaKeN

@ghost
Copy link

ghost commented Aug 23, 2016

See #4596.

This is a new feature to crowdsource data. Change enable_social to false in your config.json to disable it.

@takenek
Copy link
Author

takenek commented Aug 23, 2016

So mayby disable enable_social as default?
I update everyday configs and whole bot and checking :-) so if You merge this to master i am sure many many ppl report this spam...

@Tych0n
Copy link

Tych0n commented Aug 23, 2016

Well, we just need to remove such intensive logging, cause the more botters contribute into spawn data, the better it is for all of us.

@MasterCATZ
Copy link

its good spam , but definitely needs an option to enable / disable being displayed

@faegan
Copy link

faegan commented Aug 23, 2016

@MasterCATZ it already has that option in config.json -> enable_social = false

@HecticSeptic
Copy link

HecticSeptic commented Aug 23, 2016

@faegan @MasterCATZ it appears disabling enable_social does not only hide the spam, it stops contributing to the list of pokemon spawns we're crowdsourcing. We need to enable the crowdsource while still hiding the logging (which goes away if you [successfully] run the server in map-chat, but since that isn't on by default most users will just see excessive logging).

Edit: Ln 19 of pokemongo_bot\event_handlers\social_handler.py contains:
print msg.topic+" "+str(msg.qos)+" "+str(msg.payload)
Maybe replacing this with return will still contribute without logging (seems to work)

@Tych0n
Copy link

Tych0n commented Aug 23, 2016

@BreezeRo check this issue please

@Gobberwart
Copy link
Contributor

Seems fixed in latest dev. Best guess is it was there for debugging and didn't get removed before merging.

@mjmadsen
Copy link
Contributor

Yes, set social to disabled and this won't appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants