Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Highlight.js #80

Open
doamatto opened this issue May 26, 2021 · 1 comment · May be fixed by #171
Open

Update Highlight.js #80

doamatto opened this issue May 26, 2021 · 1 comment · May be fixed by #171
Assignees
Labels
enhancement New feature or content

Comments

@doamatto
Copy link
Collaborator

What do you want added to PrivacySpy?
When running gulp to build the site, I get the following warning:

Version 9 of Highlight.js has reached EOL and is no longer supported.
Please upgrade or ask whatever dependency you are using to upgrade.
https://github.com/highlightjs/highlight.js/issues/2877

It seems the source is from the seemingly abandoned helpers/handlebars-helpers package we use. The easiest option is to try and maintain it ourselves or find someone who already is doing so. A harder option is to find an alternative to replace it at build time.
This issues should probably have the assign expanded to both @milesmcc and @ibarakaiev since this is a pretty big thing based on the realistic resolution options.

Have you considered implementing this addition yourself and submitting a pull request?
If we come to a conclusion as to handle this, I can gladly try to impliment it myself.

@doamatto doamatto added the enhancement New feature or content label May 26, 2021
@privacyspy-bot
Copy link

Thanks for submitting this issue. @milesmcc has been assigned to determine next steps.

To learn about the PrivacySpy contribution process, check out the contribution guide.

@doamatto doamatto linked a pull request Aug 6, 2023 that will close this issue
@doamatto doamatto linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants