Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link checker misses iframe links #789

Open
nuke-web3 opened this issue Jul 27, 2023 · 0 comments
Open

Link checker misses iframe links #789

nuke-web3 opened this issue Jul 27, 2023 · 0 comments
Labels
bug Something isn't working maybe-someday Dreaming of what we can and should do

Comments

@nuke-web3
Copy link

For example in https://github.com/Polkadot-Blockchain-Academy/pba-content/pull/787/files#diff-d5beee2baeb5598821ff793b07f33f9f8cfc5463339f2981ac0924ff996d7e98R257 :

<iframe width="1440" height="646" data-src="https://www.youtube-nocookie.com/embed/meNlOrdQJFo?autoplay=1&showinfo=0&controls=0&mute=1"data-preload data-autoplay></iframe>

This is not checked by our tooling to be a link, and ideally it would be able to check if that video is no longer working (some HTML code I hope other than 200 is thrown if the video is removed for example)
@nuke-web3 nuke-web3 added bug Something isn't working maybe-someday Dreaming of what we can and should do labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working maybe-someday Dreaming of what we can and should do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nuke-web3