Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rescanblockchain absent from query #120

Open
phe-sto opened this issue Jan 10, 2021 · 2 comments
Open

rescanblockchain absent from query #120

phe-sto opened this issue Jan 10, 2021 · 2 comments

Comments

@phe-sto
Copy link
Contributor

phe-sto commented Jan 10, 2021

Hi,
The rescanblockchain method is absent. It is a really useful command to insert several private keys without rescanning and only rescan once they are all inserted.
The BitcoinRPCClient as a READ_TIMEOUT private static final of 1 minute. It is too short for rescanning after a single import passing the option to importprivatekey or rescanning with rescanblockchain.
On my computer, I have a branch where an attribute replace READ_TIMEOUT, it can therefore be change and adapted for specific queries. I was then able to add the rescanblockchain.
Is there an important reason why READ_TIMEOUT private static final is used for connection timeout? Otherwise do you want me to make a PR with this version of the class and the rescanblockchain query?
Best regards,

@Polve
Copy link
Owner

Polve commented Jan 10, 2021

Hello, we don't use that method so I never faced the problem. If you want to try working on it, a PR is welcome.

@phe-sto
Copy link
Contributor Author

phe-sto commented Jan 10, 2021

Thanks, I will try to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants