Skip to content
This repository has been archived by the owner on Mar 13, 2020. It is now read-only.

Update to Redux v4 #76

Closed
abdonrd opened this issue May 5, 2018 · 8 comments
Closed

Update to Redux v4 #76

abdonrd opened this issue May 5, 2018 · 8 comments

Comments

@abdonrd
Copy link
Contributor

abdonrd commented May 5, 2018

https://github.com/reactjs/redux/releases/tag/v4.0.0

@notwaldorf
Copy link
Contributor

@abdonrd I haven't looked much into Redux 4 -- do you expect this to be just a dependency update, or to actually require code changes?

@frankiefu
Copy link
Member

There is an issue with redux-devtools-extension + Redux v4: reduxjs/redux#2943

Because of that and maybe other compatibility issues react-boilerplate also hasn't updated to Redux v4 yet.

@notwaldorf
Copy link
Contributor

Cool, lets hold off it for a bit then! Thanks for investigating, Frankie! ❤️

@Dabolus
Copy link
Contributor

Dabolus commented May 11, 2018

Ok so, looking at Redux 4 breaking changes, it seems like nothing will affect this project. To test this out, I tried to clone the repo and simply update the redux dependency. As @frankiefu already said, redux devtools will break everything, but in an incognito window everything kept working like a charm, so I can confirm that besides the devtools extension problem, updating to Redux 4 does not require any changes in the code. The great thing is that Redux 4 does not depend on lodash anymore, so we will save a lot of extra bytes too (and it is also much faster!)

@abdonrd
Copy link
Contributor Author

abdonrd commented May 11, 2018

@notwaldorf with the comments of @frankiefu and @Dabolus, I have nothing more to say! 😁

@Dabolus
Copy link
Contributor

Dabolus commented Jun 12, 2018

Small update: seems like redux-devtools-extension has been abandoned 😕

@AshGrowem
Copy link

AshGrowem commented Jun 23, 2018

@notwaldorf @frankiefu I think the incompatibility issue just got resolved?

Someone should test it out! According to this comment, it right now only works from manually installing the latest npm package.

@Dabolus 9 new commits 🌱since June 15th, so it looks like the redux-devtools-extension repo was brought back to life! ☺️

Also react-boilerplate is now updated to Redux v4

@Dabolus
Copy link
Contributor

Dabolus commented Jun 23, 2018

@ashrafhadden nice to see that collaborators brought it back to life! The original author is still inactive, though. I hope someone else manages to update the extension on the chrome web store so that we can safely migrate to Redux 4!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants