Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always compile for MSEdge <= 38 #1128

Closed
valdrinkoshi opened this issue Mar 1, 2017 · 1 comment
Closed

Always compile for MSEdge <= 38 #1128

valdrinkoshi opened this issue Mar 1, 2017 · 1 comment
Assignees
@aomarks
Labels
Package: polyserve Priority: High Status: Available Type: Bug

Comments

@valdrinkoshi
Copy link
Member

In Microsoft Edge 38.14393.0.0 (Microsoft EdgeHTML 14.14393), ES6 constructor returns class instead of an instance (see chakra-core/ChakraCore#1496).
In this case polyserve should compile resources.
@valdrinkoshi valdrinkoshi changed the title Always compile for MSEdge Always compile for MSEdge <= 38 Mar 1, 2017
aomarks referenced this issue in Polymer/polyserve Apr 11, 2017
@aomarks
Require ES5 compilation for Edge < 40.
cf199ac 
Fixes #161. Versions before 40 have a JIT bug where a constructor can
return the class instead of an instance.

See chakra-core/ChakraCore#2532 and
chakra-core/ChakraCore#2532.

Tested with http://jsfiddle.net/0k59gbL8/5/. Fails on 38, passes on 40.
aomarks referenced this issue in Polymer/polyserve Apr 11, 2017
@aomarks
Require ES5 compilation for Edge < 40.
a144418 
Fixes #161. Versions before 40 have a JIT bug where a constructor can
return the class instead of an instance.

See chakra-core/ChakraCore#2532 and
chakra-core/ChakraCore#2532.

Tested with http://jsfiddle.net/0k59gbL8/5/. Fails on 38, passes on 40.
aomarks referenced this issue in Polymer/polyserve Apr 11, 2017
@aomarks
Require ES5 compilation for Edge < 40.
549aa8f 
Fixes #161. Versions before 40 have a JIT bug where a constructor can
return the class instead of an instance.

See chakra-core/ChakraCore#1496 and
chakra-core/ChakraCore#2532.

Tested with http://jsfiddle.net/0k59gbL8/5/. Fails on 38, passes on 40.
aomarks referenced this issue in Polymer/polyserve Apr 11, 2017
@aomarks
Require ES5 compilation for Edge < 40. (#173)
2474e05 
Fixes #161. Versions before 40 have a JIT bug where a constructor can
return the class instead of an instance.

See chakra-core/ChakraCore#1496 and
chakra-core/ChakraCore#2532.

Tested with http://jsfiddle.net/0k59gbL8/5/. Fails on 38, passes on 40.
aomarks referenced this issue in Polymer/polyserve Apr 12, 2017
@aomarks
Check Edge versions correctly in compilation switch.
79d3468 
Really fixes #161. This time for real! My previous PR #173 assumed that
the Edge user agent used the main browser release version. Actually it
uses the EdgeHTML version. The fix we care about for the original issue
is in a major release of Edge, but a minor release of EdgeHTML, so we
have to check minor version now too.

https://en.wikipedia.org/wiki/Microsoft_Edge#Release_history

Also added a test and a small refactor so that we can paste real user
agent strings.
@aomarks
Copy link
Member

aomarks commented Apr 12, 2017

Re-opening since my PR was checking the wrong versioning scheme (user agent contains EdgeHTML version, not main release version).

@aomarks aomarks reopened this Apr 12, 2017
aomarks referenced this issue in Polymer/polyserve Apr 12, 2017
@aomarks
Check Edge versions correctly in compilation switch. (#174)
2b2aa70 
Really fixes #161. This time for real! My previous PR #173 assumed that
the Edge user agent used the main browser release version. Actually it
uses the EdgeHTML version. The fix we care about for the original issue
is in a major release of Edge, but a minor release of EdgeHTML, so we
have to check minor version now too.

https://en.wikipedia.org/wiki/Microsoft_Edge#Release_history

Also added a test and a small refactor so that we can paste real user
agent strings.

Also note this uses destructuring, so we are no longer node 4 compatible.
@aomarks aomarks transferred this issue from Polymer/polyserve Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aomarks aomarks

Labels
Package: polyserve Priority: High Status: Available Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aomarks @valdrinkoshi