Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy command #2035

Open
justinfagnani opened this issue Apr 29, 2016 · 8 comments
Open

Add deploy command #2035

justinfagnani opened this issue Apr 29, 2016 · 8 comments

Comments

@justinfagnani
Copy link
Contributor

The basic command should be:

polytool deploy <target>

Where target might be gh-pages, app-engine, firebase, etc.

It looks like wrapping https://www.npmjs.com/package/ship is a good way to start. They have a gh-pages deployer and a deployer abstraction. There are no App Engine or Firebase deployers yet, those there are issues to track them: app-engine firebase.

If we create these deployers, I'd rather not write and maintain CoffeeScript, so we can start another repo and write them in ES2015 or TypeScript.

@FredKSchott
Copy link
Contributor

@justinfagnani contributing these into the ship repo in any language would be preferable to owning them all by ourselves.

Starting work on this now! 💃💃💃

@FredKSchott
Copy link
Contributor

To update this ticket, I wasn't able to spend much time on this. Unassigning from myself for now until we can prioritize for v1.1.

@FredKSchott FredKSchott removed their assignment May 17, 2016
@chuckh
Copy link
Contributor

chuckh commented May 23, 2016

We may need to consider another option then ship. From ship readme:

⛔ ⛔ We are no longer supporting the ship project. ⛔ ⛔

Explanation: We have found that supporting these different deployment platforms is too difficult for us to keep up with right now. We may re-start this project in the future, but for now you should use it at your own risk

See https://github.com/carrot/ship/blob/master/readme.md.

@addyosmani
Copy link
Member

We spoke to @samccone at some point about us helping to maintain Ship or fork. I'd be curious if that's something we are still interested in.

@samccone
Copy link
Contributor

It is prob worth a fork or just using it as a base :)

@chuckh
Copy link
Contributor

chuckh commented Jun 5, 2016

If we fork or use ship as a base I would encourage us to use javascript instead of coffescript.

@justinfagnani
Copy link
Contributor Author

Or TypeScript :)

So far we've found people can jump right in.

@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants