Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub branch protection on main #356

Open
guidoiaquinti opened this issue Apr 26, 2022 · 1 comment
Open

GitHub branch protection on main #356

guidoiaquinti opened this issue Apr 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@guidoiaquinti
Copy link
Contributor

Proposed change

We currently can't enable branch protection on main as we have few GH actions relying on it being disabled:

1️⃣ update-docs.yml
2️⃣ bump-version.yml
3️⃣ test-kubetest-store-durations.yaml

Alternative options

Do nothing

Additional context

Update docs could (and in my opinion should) be converted as a pre-commit hook, for the other 2 I don't have solutions yet.

@guidoiaquinti guidoiaquinti added the enhancement New feature or request label Apr 26, 2022
@macobo
Copy link
Contributor

macobo commented May 9, 2022

I think this can be solved by setting "Restrict who can push to matching branches" and making sure that commits are made by posthog bot not ourselves. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants