Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLICKHOUSE_PORT as option for externalClickhouse configs #415

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add CLICKHOUSE_PORT as option for externalClickhouse configs #415

merged 2 commits into from
Jun 2, 2022

Conversation

fuziontech
Copy link
Member

Description

Closes #414 - request for exactly this :D

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Going to write tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@fuziontech fuziontech marked this pull request as draft June 2, 2022 00:53
@macobo macobo marked this pull request as ready for review June 2, 2022 07:52
@macobo macobo requested a review from guidoiaquinti June 2, 2022 07:52
@macobo macobo added the bump patch Updates chart version by 0.0.1 label Jun 2, 2022
@macobo macobo merged commit 6cc47a0 into main Jun 2, 2022
@macobo macobo deleted the port branch June 2, 2022 07:56
macobo added a commit that referenced this pull request Jun 2, 2022
@macobo
Revert "Add CLICKHOUSE_PORT as option for externalClickhouse configs (#…
fc1d0ab 
…415)"

This reverts commit 6cc47a0.
@macobo macobo mentioned this pull request Jun 2, 2022
Merged
guidoiaquinti pushed a commit that referenced this pull request Jun 2, 2022
@macobo
Revert "Add CLICKHOUSE_PORT as option for externalClickhouse configs (#…
484f8f5 
…415)" (#417)

This reverts commit 6cc47a0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidoiaquinti guidoiaquinti Awaiting requested review from guidoiaquinti

Assignees
No one assigned
Labels
bump patch Updates chart version by 0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CLICKHOUSE_PORT configuration
2 participants
@fuziontech @macobo