Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional configuration to externalKafka #595

Open
logand22 opened this issue Oct 13, 2022 · 0 comments
Open

Add additional configuration to externalKafka #595

logand22 opened this issue Oct 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@logand22
Copy link

Proposed change

I'd like the ability to configure Kafka security protocol as well as SASL parameters via the externalKafka helm chart values.

For example:

# Ignored if `kafka.enabled` is set to `true`. 
externalKafka:
  # - External Kafka brokers. Multiple brokers can be provided as array/list.
  brokers: []
  # - External Kafka security protocol.
  securityProtocol: ""
  # - External Kafka authentication SASL Mechanism.
  saslMechanism: ""
  # - External Kafka SASL user.
  saslUser: ""
  # - External Kafka SASL password. Either this or `externalKafka.existingSecret` must be set.
  saslPassword: ""
  # - Name of an existing Kubernetes secret object containing the Kafka SASL password.
  existingSecret: ""
  # - Name of the key pointing to the password in your Kubernetes secret
  existingSecretPasswordKey: "password"

Alternative options

You can add the environment variables as defined in PostHog data sources directly through the env configuration section in .values.yaml.

This doesn't allow the user to specify a secret for the password or the ClickhouseInstallation.

Additional context

I'm deploying PostHog with Amazon MSK and would like to use SASL/SCRAM authentication but don't want to have password exposed in helm chart values. Additionally, I had to look into PostHog source code to understand how to configure this. Having these values in the helm chart could improve the UX for this chart.

@logand22 logand22 added the enhancement New feature or request label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant