Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Do action matching in plugin server #157

Closed
Twixes opened this issue Feb 17, 2021 · 3 comments
Closed

Do action matching in plugin server #157

Twixes opened this issue Feb 17, 2021 · 3 comments

Comments

@Twixes
Copy link
Collaborator

Twixes commented Feb 17, 2021

If we match fully processed events to actions in the plugin server (in parallel with saving the event to DB), we'll be able to again have asynchronous events>actions matching. Even more importantly, we'll be able to support method onAction(action: Action, event: PluginEvent) on plugins, facilitating making webhooks a plugin. In the long run something like PostHog/posthog#3357 may be built on top of this.

@mariusandra
Copy link
Collaborator

How much effort will this be? I guess we need the entire filtering logic (that is probably already implemented twice in django? Once for postgres and once for clickhouse?)... into JS. Sounds like a lot of meticulous work...

@Twixes
Copy link
Collaborator Author

Twixes commented Feb 17, 2021

The logic is actually common, because we perform matching on a temporary event created in Postgres (as storing action definitions in ClickHouse is a pain).

@Twixes
Copy link
Collaborator Author

Twixes commented Mar 10, 2021

Superseded by #235 I suppose. It's the same idea, but fleshed out more in the newer issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants