Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Even more graceful shutdown #210

Closed
mariusandra opened this issue Feb 24, 2021 · 1 comment
Closed

Even more graceful shutdown #210

mariusandra opened this issue Feb 24, 2021 · 1 comment

Comments

@mariusandra
Copy link
Collaborator

mariusandra commented Feb 24, 2021

When we deploy a new plugin server, we get errors like this: 1, 2.

These timeouts never get cleared because somehow the task itself ended early.

We should probably delay a bit more during shutdown?

@mariusandra
Copy link
Collaborator Author

Will investigate these issues as they come. Refactoring the kafka pipeline definitely silenced most of them though. Once we implement "recovery mode" as described here - https://github.com/PostHog/plugin-server/issues/353 - we will have a more graceful shutdown... as we'll need to boot up the recovery mode on normal SIGTERM shutdowns as well, to e.g. flush all memory buffers to persistent storage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant