Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Sharing Scope #3551

Closed
EDsCODE opened this issue Mar 2, 2021 · 9 comments
Closed

Dashboard Sharing Scope #3551

EDsCODE opened this issue Mar 2, 2021 · 9 comments
Labels
enhancement New feature or request feature/dashboards Feature Tag: Dashboards

Comments

@EDsCODE
Copy link
Member

EDsCODE commented Mar 2, 2021

Reprioritized #3344 into a list that can be tackled for this cycle for dashboard sharing. I've grouped several of the collaboration features into a format I think would allow them to all work well together.

Collaboration:

  • When clicking on a dashboard item, don't directly go to insights editor but instead provide a focus on the insight being viewed and provide details on
    • versions—how the dashboard item has been changed
    • comments from team members
    • allow sharing of this item specifically
    • description of the dashboard item
    • a detail on the dashboard item itself that denotes when it was last updated and how many comments/notes are on it

*The points above don't all need to be addressed but having the basis of a dedicated viewer for dashboard items will allow us to expand dashboard functionality.

Sharing:

  • Easy snapshots that can record a state of the dashboard in time. (Related idea I had a while ago: Imprints for currently changing data #1137)
  • Handle posthog link previews in slack
  • Be able to share an individual insight graph
@EDsCODE EDsCODE added the enhancement New feature or request label Mar 2, 2021
@paolodamico
Copy link
Contributor

Makes sense to me. Some questions that popped up in my head,

  • Are we doing version history on the dashboard itself? e.g. if you added or removed items?
  • Are we allowing general discussion on a dashboard (vs. just dashboard items)?
  • For handling previews in Slack (which is awesome!) we need to consider the case where you share a private link, perhaps we need you to connect your PostHog to your Slack account (like GH does?), this would be a great first foot on the door on Slack to better collaborate with our users.
  • In terms of organizing I do think tagging dashboards could be pretty powerful without requiring a ton of work, but it might be for a separate sprint?

How do we want to move forward? Happy to do some wireframes for either this or #3547. @corywatilo also don't know if there's one in particular you'd like to take on.

@corywatilo
Copy link
Contributor

corywatilo commented Mar 4, 2021

Handle posthog link previews in slack

Is this more than just authing and making sure we figure out what the og:image should show? There wouldn't be more interactivity from just pasting a link, right?

We had also talked about Slack updates for Dashboards. MVP could look like: You set up time-based (daily, weekly) updates that go into Slack that summarize the dashboard. (Could do each widget on the dashboard, but that could be a lot of updates...

P.S. a real Slack integration could open up a whole new world of app messages we push out.

Examples: aside from just analytics chart images, we could show... metrics (latest, high, low), select field to change date range, buttons to refresh, trigger something via a plugin, other cool things? And that's just for charts. Then what if a session recording is dropped in when a user hits a 500 page? Other event-based notifications.

For reference: Slack layout blocks

@paolodamico
Copy link
Contributor

Took a stab at some wireframes to encompass these new functionality plus the appropriate fixes in #3547, curious to hear people's thoughts on this.

Base dashboard

  • Added tagging functionality
  • Changed the UX of "locked" mode to be locked by default and instead enter editing mode to move things around.
  • Added keyboard shortcuts for easier navigation
  • Prioritizes sharing as the main action
  • Allows adding new graphs from a dashboard
    image

Secondary actions

  • Grouped secondary actions
  • Shows a static indicator on whether the dashboard is publicly shared
    image

Editing a dashboard

  • Edit mode as described above.
  • Maybe worth considering jiggling the dashboard items a bit like when you're reordering your home screen in iOS?
    image

Activity

  • In terms of UX, grouped version control and collaboration into a single activity timeline. This way you can linearly see all the activity relevant for the dashboard.
  • Activity an be opened within the same dashboard for easy access.
  • Shows an indicator when there's unread activity.
  • Edits to the item allow you to open the graph in the state where it was previous to the changes.
  • Fully support emoji usage. Ideally we would support @ mentions too (this will require email/Slack updates on changes to dashboards too).
    image

Graph details

  • Opens the insight page to allow editing to a graph, but adds clear communication around this being a graph within dashboard.
  • Shows the same activity history in the page.
    image

@EDsCODE
Copy link
Member Author

EDsCODE commented Mar 4, 2021

These wireframes are super helpful

Base Dashboard:

  • any thoughts on how we should include snapshots of dashboards?

Editing Dashboard:

  • Updating tint/accent colors around the page could help signal editing mode is active

Activity History:

  • my main concern here would be that the activity history of a single item and the dashboard itself look very similar right now. we'll need a way to make sure the user doesn't incorrectly associate them

Graph Details:

  • I think this is a needed direction for dashboard item editing. When you land on this page, should we restrict the editing to just the insight relevant properties? (meaning you can't change the underlying insight type from trend -> sessions but only the trend elements and corresponding filters) I think this will make the editing page much more clear.
  • should we make this page even more presentational so that users can directly share a single graph like above? (Karl had a similar direction here

@paolodamico
Copy link
Contributor

Thanks for the feedback @EDsCODE, based on it and the wireframes I've gone ahead and started on some wireframes. Hoping to get some feedback so we can start building soon.

  • Re base dashboard. Starting from the default mode (i.e. not the build mode), we could just remove the action elements (buttons and such), plus the navigation, and then it could be easily printed / exported to PDF. We could use the same visual concept for snapshots, wdyt?
  • Re editing dashboard. 👍
  • Re activity history. I was actually thinking we would start with having history only on dashboard items, we would just have two ways of accessing it, 100% agree that having it this way for both would be quite confusing.
  • Re graph details. 1) 👍 definitely; 2) that is a very interesting idea, we could have a presentation/default mode and an edit mode for dashboard items. Let me explore it too.

@paolodamico
Copy link
Contributor

Initial mockups ready on Figma, would love some feedback please!

image

@jamesefhawkins
Copy link
Collaborator

Just a note - collaboration-focussed features = paid, creation-focussed features = free. @paolodamico - I'd be curious how you'd make this call here?

@paolodamico
Copy link
Contributor

Great point @jamesefhawkins forgot to consider that.

  • Definitely the commenting thing that we'll introduce is 100% collaborative and will make it a premium feature.
  • The general improvements on UX will apply for everyone.
  • Sharing dashboards is definitely collaborative but we already had it as a free feature. Wondering if we should make it paid.
  • Unsure about the dashboard history/version control. That seems useful for individual use too. Though seems pretty fair to include as premium feature. Inclined to introduce as premium on the basis that is mainly collaborative. Thoughts ?

@timgl
Copy link
Collaborator

timgl commented Apr 27, 2021

Sharing dashboards is definitely collaborative but we already had it as a free feature. Wondering if we should make it paid.

As a rule we can only move features from being premium to being open source, but not the other way around

Unsure about the dashboard history/version control. That seems useful for individual use too. Though seems pretty fair to include as premium feature. Inclined to introduce as premium on the basis that is mainly collaborative. Thoughts ?

Yes let's start with this being a premium feature, can always move it to free (but not other way around)

cc @liyiy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/dashboards Feature Tag: Dashboards
Projects
None yet
Development

No branches or pull requests

6 participants