Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Notebook API support #3176

Closed
3 tasks done
andyleejordan opened this issue Feb 9, 2021 · 6 comments · Fixed by #3177
Closed
3 tasks done

Remove Notebook API support #3176

andyleejordan opened this issue Feb 9, 2021 · 6 comments · Fixed by #3177
Assignees

Comments

@andyleejordan
Copy link
Member

andyleejordan commented Feb 9, 2021

The Notebook API support was partially implemented but based on early Visual Studio Code APIs which have yet to be finalized. Since our support is experimental, it probably ought to have been in a feature branch. So we're planning to:

  • Turn off the GitHub actions which open new PRs updating our use of the experimental APIs
  • Remove the Notebook code from the extension itself
  • Save the prototype in a feature branch to be revisited in the future

/cc @TylerLeonhardt @rjmholt @SydneyhSmith

@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 9, 2021
@rjmholt
Copy link
Contributor

rjmholt commented Feb 9, 2021

Yeah I think the key issue for us is that we had assumed the VSCode notebook APIs would stabilise sooner than it has, so it was acceptable to take the incremental changes in the meantime.

We've proven the concept (and helped VSCode develop their API), but managing the update PRs has become an ongoing burden — the simplest solution is for us to wait for the API to be exposed stably by VSCode and then to re-enable our notebook integration code.

@andyleejordan
Copy link
Member Author

That "feature branch" is just the fact that it's in the history as a merged PR 😅

@dkattan
Copy link

dkattan commented Mar 5, 2021

Damn, I was just sitting down to finally play with this lol.

@andyleejordan
Copy link
Member Author

It'll come back one day! Just when the VS Code API is stable and we can integrate with it properly. For now, we're focussing on much-needed stabilization work for the extension. 😄

@janegilring
Copy link
Contributor

What are the current status of the VS Code API and plans to integrate the Notebook API?

@ghost
Copy link

ghost commented Mar 10, 2023

Thank you for your comment, but please note that this issue has been closed for over a week. For better visibility, consider opening a new issue with a link to this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants