Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write-Progress not cleaned up unless -Complete is explicitly specified #3807

Closed
5 tasks done
JustinGrote opened this issue Feb 3, 2022 · 6 comments · Fixed by PowerShell/PowerShellEditorServices#1719
Closed
5 tasks done
Assignees

Comments

@JustinGrote
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.

Summary

image

If you do a -complete it will go away. In normal PS it will go away at end of execution and return to prompt, so the "return to prompt" handling that happens in progress must not be happening in our host.

PowerShell Version

Preview

Visual Studio Code Version

Insiders

Extension Version

Preview

Steps to Reproduce

Write-Progress 'test'

Hit enter a few times

Visuals

No response

Logs

No response

@JustinGrote JustinGrote added the Issue-Bug A bug to squash. label Feb 3, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 3, 2022
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Feb 3, 2022
@andyleejordan andyleejordan self-assigned this Feb 3, 2022
@StevenBucher98 StevenBucher98 removed the Needs: Triage Maintainer attention needed! label Feb 9, 2022
@andyleejordan
Copy link
Member

I can repro this. Any thoughts on how to fix?

@JustinGrote
Copy link
Collaborator Author

@andschwa I wonder if this is a PSHost thing that has to be reimplemented, since a lot of that went away.

@andyleejordan
Copy link
Member

@JustinGrote Write-Progress is also totally broken in stable, right?

@andyleejordan
Copy link
Member

FWIW I tried using _consoleHostUI instead of _underlyingHostUI and it made no difference.

@andyleejordan
Copy link
Member

Linking @SeeminglyScience's potential fix: #3423 (comment)

@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Feb 19, 2022
@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Feb 19, 2022
@andyleejordan andyleejordan changed the title Write-Progress not cleaned up unless -Complete is explicitly specified Write-Progress not cleaned up unless -Complete is explicitly specified Feb 22, 2022
Repository owner moved this from In Progress to Done in Sea Biscuit Feb 23, 2022
@andyleejordan
Copy link
Member

The fix for this is out in PowerShell Preview v2022.2.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants