Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach to process debugging #3849

Closed
andyleejordan opened this issue Feb 23, 2022 · 9 comments
Closed

Fix attach to process debugging #3849

andyleejordan opened this issue Feb 23, 2022 · 9 comments
Assignees
Labels
Area-Debugging Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.

Comments

@andyleejordan
Copy link
Member

This is tied into "remote debugging" and we need to be sure it works.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 23, 2022
@JustinGrote
Copy link
Collaborator

There is still a big issue, more about runspaces, that entering a runspace still hangs the console. This is a "big deal" showstopper for doing any kind of debugging in this environment.

@andyleejordan
Copy link
Member Author

Completely agree!

@andyleejordan
Copy link
Member Author

It's probably our last and biggest blocker to move the preview to stable.

@StevenBucher98 StevenBucher98 added Area-Debugging Needs: Fix Verification Please verify the fix for us! and removed Needs: Triage Maintainer attention needed! labels Feb 28, 2022
@andyleejordan
Copy link
Member Author

andyleejordan commented Feb 28, 2022

Just running the "attach process" kinda works? I mean it's broken in a lot of ways too, and I'm not sure how it's supposed to work.

@SeeminglyScience
Copy link
Collaborator

Attach to process definitely doesn't work.

  1. Doesn't Debug-Runspace after entering the target process
  2. If you do it manually, breakpoints aren't transferred
  3. Trying to abort the debug session dead locks the session completely

Note, unfortunately this is a potentially quite large work item and was the most difficult piece to fix when I integrated PSRL years ago. I have also verified it does work in stable. Pretty finicky, but definitely usable.

Hopefully easier to fix with the improved architecture though 🤞

@SeeminglyScience SeeminglyScience added Bug: Pre-release Bugs reproducing only in the pre-release extension. and removed Needs: Fix Verification Please verify the fix for us! labels Mar 1, 2022
@SeeminglyScience
Copy link
Collaborator

We also need to test (after this is fixed) if debugging an azure function still works.

@andyleejordan
Copy link
Member Author

😭 I hope it ends up being easier to fix than we think!

@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Mar 3, 2022
@andyleejordan andyleejordan changed the title Verify attach to process scenario works Fix (or disable) "attach to process" debugging Mar 15, 2022
@andyleejordan
Copy link
Member Author

Thanks @SeeminglyScience!

Repository owner moved this from In Progress to Done in Sea Biscuit Apr 18, 2022
@andyleejordan andyleejordan added Issue-Bug A bug to squash. Resolution-Fixed Will close automatically. labels Apr 18, 2022
@JustinGrote
Copy link
Collaborator

Can confirm this years-long bug is finally fixed in preview. You can debug an Azure Functions worker and get repl at the console at that point.
image

@SydneyhSmith SydneyhSmith changed the title Fix (or disable) "attach to process" debugging Fix attach to process" debugging Jun 14, 2022
@SydneyhSmith SydneyhSmith changed the title Fix attach to process" debugging Fix attach to process debugging Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Debugging Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants