Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt #4041

dbrennand · 2022-06-23T13:42:52Z

Prerequisites

I have written a descriptive issue title.
I have searched all issues to ensure it has not already been reported.
I have read the troubleshooting guide.
I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
If this is a security issue, I have read the security issue reporting guidance.

Summary

My vscode-powershell extension updated this morning to [email protected] and I'm having an issue where the selection of code I'm running with F8 is executed but then is recalled immediately into the integrated console prompt.

Example:

=====> PowerShell Integrated Console v2022.6.1 <=====

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.2
PSEdition                      Core
GitCommitId                    7.2.2
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS> Write-Output -InputObject "Hi!"
Hi!
PS> Write-Output -InputObject "Hi!"

It's as if the console history is being immediately recalled into the console prompt without additional input.

Rolling back to [email protected] fixes the issue:

=====> PowerShell Integrated Console v2022.5.1 <=====

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.2
PSEdition                      Core
GitCommitId                    7.2.2
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS> Write-Output -InputObject "Hi!"
Hi!
PS>

The latest preview extension [email protected] exhibits the same behaviour as v2022.6.1.

Could this be caused by PowerShell/PowerShellEditorServices#1823?

PowerShell Version

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.2
PSEdition                      Core
GitCommitId                    7.2.2
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

PS> code --version
1.68.1
30d9c6cd9483b2cc586687151bcbcd635f373630
x64

Extension Version

PS> code --list-extensions --show-versions | Select-String powershell

[email protected]
[email protected]

Steps to Reproduce

Write-Output -InputObject "Hi!"

With [email protected] installed, launch the PowerShell integrated console.
Select line(s) of code in the editor window and run using F8.
The code is executed.
The executed lines of code are recalled immediately into the integrated console prompt.

Visuals

No response

Logs

No response

The text was updated successfully, but these errors were encountered:

cblackuk · 2022-06-23T13:49:14Z

Thanks @dbrennand - I am having the same issue on multiple systems.

andyleejordan · 2022-06-23T16:26:42Z

I think you're probably right about it being PowerShell/PowerShellEditorServices#1823. /cc @SeeminglyScience

andyleejordan · 2022-06-23T16:44:57Z

I'm having trouble reproducing this. Can you share more environment info? @SeeminglyScience sees it only after first causing an error in the PSIC, but neither of you mentioned this. I'm using PS 7.2.4 on macOS.

andyleejordan · 2022-06-23T16:48:59Z

Ok seems to be Windows-only? Repro'd (without throwing an error first) on PS 7.2.4 on Windows.

cblackuk · 2022-06-23T16:49:38Z

To me it was on a Windows Sever 2019 and WS2022 - brand new session, just after upgrading - the F8 button started pasting the code "twice" as @dbrennand explained.

Name                           Value
----                           -----
PSVersion                      7.2.4
PSEdition                      Core
GitCommitId                    7.2.4
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

And

Name                           Value
----                           -----
PSVersion                      7.2.5
PSEdition                      Core
GitCommitId                    7.2.5
OS                             Microsoft Windows 10.0.20348
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

It is also worth mentioning that I can repro it on Windows PowerShell 5.1 on the same boxes :-)

dbrennand · 2022-06-23T17:10:05Z

Reproduced on a different Windows system than I initially submitted the issue on:

Windows 10 21H1 (OS Build: 19043.1766)

=====> PowerShell Integrated Console v2022.6.1 <=====

PS C:\Users\dab> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.4
PSEdition                      Core
GitCommitId                    7.2.4
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS C:\Users\dab> 
PS C:\Users\dab> Write-Output -InputObject "Hi!"
Hi!
PS C:\Users\dab> Write-Output -InputObject "Hi!"

I can also reproduce this on Linux with WSL on the same system as above:

dab@DESKTOP:~$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"

=====> PowerShell Integrated Console v2022.6.1 <=====

PS /home/dab> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.5
PSEdition                      Core
GitCommitId                    7.2.5
OS                             Linux 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS /home/dab> 
PS /home/dab> Write-Output -InputObject "Hi!"
Hi!
PS /home/dab> Write-Output -InputObject "Hi!"

andyleejordan · 2022-06-23T21:12:33Z

Fix in PR!

cblackuk · 2022-06-23T21:14:32Z

That is so awesome :) thanks for such a quick turnaround :)

dbrennand · 2022-06-23T22:04:17Z

Wow! Awesome! 🚀 Thanks for the quick turnaround! @andschwa @SeeminglyScience!

tropez1971 · 2022-06-29T15:32:02Z

Same issue, even running the latest PowerShell Preview v2022.6.2.

If this is fixed, how do I get my hands on it? Very annoying right now.

pascalkrielen · 2022-06-29T15:59:08Z

Same issue, noticed that when selecting text and hitting F8 the error occurs, when putting focus back on editor and running SAME lines with f8 it does not happen. When selecting other lines it happens again.

andyleejordan · 2022-06-29T17:37:21Z

Working on getting a preview out right now! I got stuck trying to get a new end-to-end test in yesterday, sorry!

cblackuk · 2022-06-29T18:56:35Z

Thanks @andschwa for your efforts :) really appreciate it!

For @tropez1971 and @pascalkrielen - for now I would suggest manually downgrading to v2022.5.1 which is what I did for now :-) I hope that helps :-)

dbrennand · 2022-06-30T07:41:58Z

@tropez1971 @pascalkrielen @andschwa @cblackuk Just testing v2022.6.3-preview with the fix and I can no longer reproduce! 🚀 🙂

andyleejordan · 2022-06-30T18:25:16Z

Yay, glad to hear it @dbrennand! We're looking to move that preview to stable today, give it a good thorough whack of testing!

cblackuk · 2022-07-01T08:04:40Z

Super happy to confirm that v2022.6.3 is working fine now!!! Thanks a lot everyone :D Great effort!

dbrennand · 2022-07-01T08:07:42Z

Yep, can no longer reproduce in v2022.6.3 🚀 🥳 - Thanks all! 🙂

tlgill · 2022-07-01T18:36:33Z

Bless you - I have been trying to figure this out for several days. Its not show-stopping but just very annoying. At first it seemed related to the terminal settings in VS Code but nothing I changed or set back to default helped. Reinstalled a bunch of things and updated other modules. Finally tracked it down to the module and found this article/PR. I updated the module to v2022.6.3 and can verify the issue is gone!!!

ed... too many 2s...

andyleejordan · 2022-07-01T18:59:59Z

Sorry about that! We did not mean to introduce that bug, it was clearly very annoying. Ok, not that we mean to introduce any bug 😅

dbrennand added the Issue-Bug A bug to squash. label Jun 23, 2022

ghost added the Needs: Triage Maintainer attention needed! label Jun 23, 2022

andyleejordan added Area-Extension Terminal and removed Needs: Triage Maintainer attention needed! labels Jun 23, 2022

andyleejordan assigned andyleejordan and SeeminglyScience Jun 23, 2022

andyleejordan added this to American Pharoah Jun 23, 2022

andyleejordan added the OS-Windows label Jun 23, 2022

andyleejordan mentioned this issue Jun 23, 2022

Add command to PSReadLine history before cancellation PowerShell/PowerShellEditorServices#1841

Merged

andyleejordan removed the OS-Windows label Jun 23, 2022

andyleejordan closed this as completed in PowerShell/PowerShellEditorServices#1841 Jun 24, 2022

andyleejordan moved this to Done in American Pharoah Jun 24, 2022

andyleejordan mentioned this issue Jun 27, 2022

Path to script inserted into console on F5 #4047

Closed

6 tasks

oloflindberg mentioned this issue Jun 28, 2022

'Run selection' (F8) does not work as expected after upgrading to 2022.6.1 #4052

Closed

6 tasks

This was referenced Jun 28, 2022

Run Selection [F8] Double sends #4055

Closed

Duplication of last command into terminal #4056

Closed

andyleejordan changed the title ~~Run selection with F8 causes executed code to be recalled into the integrated console prompt~~ Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt Jun 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt #4041

Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt #4041

dbrennand commented Jun 23, 2022 •

edited

Loading

cblackuk commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

cblackuk commented Jun 23, 2022 •

edited

Loading

dbrennand commented Jun 23, 2022 •

edited

Loading

andyleejordan commented Jun 23, 2022

cblackuk commented Jun 23, 2022

dbrennand commented Jun 23, 2022

tropez1971 commented Jun 29, 2022

pascalkrielen commented Jun 29, 2022

andyleejordan commented Jun 29, 2022

cblackuk commented Jun 29, 2022

dbrennand commented Jun 30, 2022 •

edited

Loading

andyleejordan commented Jun 30, 2022

cblackuk commented Jul 1, 2022

dbrennand commented Jul 1, 2022

tlgill commented Jul 1, 2022 •

edited

Loading

andyleejordan commented Jul 1, 2022

Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt #4041

Run selection with F8 causes executed code to be recalled / duplicated into the integrated console prompt #4041

Comments

dbrennand commented Jun 23, 2022 • edited Loading

Prerequisites

Summary

PowerShell Version

Visual Studio Code Version

Extension Version

Steps to Reproduce

Visuals

Logs

cblackuk commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

andyleejordan commented Jun 23, 2022

cblackuk commented Jun 23, 2022 • edited Loading

dbrennand commented Jun 23, 2022 • edited Loading

andyleejordan commented Jun 23, 2022

cblackuk commented Jun 23, 2022

dbrennand commented Jun 23, 2022

tropez1971 commented Jun 29, 2022

pascalkrielen commented Jun 29, 2022

andyleejordan commented Jun 29, 2022

cblackuk commented Jun 29, 2022

dbrennand commented Jun 30, 2022 • edited Loading

andyleejordan commented Jun 30, 2022

cblackuk commented Jul 1, 2022

dbrennand commented Jul 1, 2022

tlgill commented Jul 1, 2022 • edited Loading

andyleejordan commented Jul 1, 2022

dbrennand commented Jun 23, 2022 •

edited

Loading

cblackuk commented Jun 23, 2022 •

edited

Loading

dbrennand commented Jun 23, 2022 •

edited

Loading

dbrennand commented Jun 30, 2022 •

edited

Loading

tlgill commented Jul 1, 2022 •

edited

Loading