scheduling bug when events in init scheduled for end(sim) using option spades.allowInitDuringSimInit

[achubaty]

When spades.allowInitDuringSimInit is TRUE, SpaDES.core executes init events in a new simulation, with a modified end time, meaning any events using end(sim) will have those events scheduled for this modified time, and not the actual end time.

This block in resolveDepsRunInitIfPoss is likely the source of the problem:

  if (getOption("spades.allowInitDuringSimInit", TRUE)) {
      ...
      squash <- withCallingHandlers({
        simAlt <- simInit(modules = canSafelyRunInit, paths = paths, params = params,
                          objects = objects, inputs = inputs, outputs = outputs,
                          times = list(start = as.numeric(start(sim)),
                                       end = as.numeric(start(sim)), timeunit = timeunit(sim)))
        simAlt@.xData$._ranInitDuringSimInit <- completed(simAlt)$moduleName
        messageVerbose(crayon::yellow("**** Running spades call for:", safeToRunModules, "****"))
        simAltOut <- spades(simAlt, events = "init", debug = debug)
      })

Note that end time is set to start time.

For now, this can be worked around by scheduling the scheduling of affected events for later.
E.g., ianmseddy/gmcsDataPrep@8bfe8dd