Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for skip & limit #9

Open
art1c0 opened this issue Oct 6, 2017 · 2 comments
Open

Support for skip & limit #9

art1c0 opened this issue Oct 6, 2017 · 2 comments

Comments

@art1c0
Copy link

art1c0 commented Oct 6, 2017

It would be nice to have an option to set the limit of populated items - as there can be thousands of them and it's not very useful to have such a huge response...

If we can also support a skip parameter - that would be just perfect.

I see you have removed the limit option, can we put it back?

@art1c0 art1c0 changed the title Support for skip/limit Support for skip & limit Oct 6, 2017
@s-taylor
Copy link
Contributor

s-taylor commented Oct 12, 2017

This option was removed as I wasn't sure of a use case where this would be useful?
If there are a bunch of associated records, I wasn't sure what value there would be populating some of them, because it would effectively be random which ones you get?

Unfortunately I've lost access to this repo though, so am not able to make further changes, see
#8

@art1c0
Copy link
Author

art1c0 commented Oct 12, 2017

Thank you for the explanation!
In fact this option would be quite useful, especially together with "skip", as it even allows to make pagination of populated objects... Or at least it would be possible to get some "last 10" elements using "sort" parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants