Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue taking money when buying furniture. #71

Closed
iLickPandas21 opened this issue Jul 30, 2023 · 4 comments
Closed

Issue taking money when buying furniture. #71

iLickPandas21 opened this issue Jul 30, 2023 · 4 comments

Comments

@iLickPandas21
Copy link
Contributor

iLickPandas21 commented Jul 30, 2023

ps-housing:server:buyFurniture

if price > PlayerData.money.bank then
    Player.Functions.RemoveMoney('bank', price, "Bought furniture")
else
    Player.Functions.RemoveMoney('cash', price, "Bought furniture")
end

Should be

if price > PlayerData.money.bank then
    Player.Functions.RemoveMoney('cash', price, "Bought furniture")
else
    Player.Functions.RemoveMoney('bank', price, "Bought furniture")
end
@MonkeyWhisper
Copy link
Member

MonkeyWhisper commented Jul 30, 2023

Why are you opening a issue? Send a PR if you want to change it. The only difference is first bank then cash which really don't matter.

@iLickPandas21
Copy link
Contributor Author

I don't have access to push a branch.

That's not the issue though, before this it checks whether you have either enough cash or enough bank. If you have enough cash but not enough bank, it'll check if the price is greater than the bank then take from the bank when you don't have enough. It should be taking cash if the cost is greater than the bank.

@iLickPandas21
Copy link
Contributor Author

I forgot that I need to fork first. I'll put a PR in.

@iLickPandas21
Copy link
Contributor Author

#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants