Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch worker is not thread-safe #80

Closed
Murazaki opened this issue Jan 27, 2023 · 1 comment
Closed

Fetch worker is not thread-safe #80

Murazaki opened this issue Jan 27, 2023 · 1 comment

Comments

@Murazaki
Copy link
Contributor

Murazaki commented Jan 27, 2023

New error at close

Unreal Engine 5.1

Assertion failed: Module [File:D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Modules\ModuleManager.cpp] [Line: 393] GitSourceControl

UnrealEditor_Core!FModuleManager::LoadModuleChecked() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Modules\ModuleManager.cpp:393]
UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseFileStatusResult() [---------\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1073]
UnrealEditor_GitSourceControl!GitSourceControlUtils::ParseStatusResults() [---------\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1221]
UnrealEditor_GitSourceControl!GitSourceControlUtils::RunUpdateStatus() [---------\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlUtils.cpp:1453]
UnrealEditor_GitSourceControl!FGitFetchWorker::Execute() [---------\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlOperations.cpp:689]
UnrealEditor_GitSourceControl!FGitSourceControlCommand::DoThreadedWork() [---------\Plugins\UEGitPlugin\Source\GitSourceControl\Private\GitSourceControlCommand.cpp:46]
UnrealEditor_Core!FQueuedThreadPoolWrapper::FScheduledWork::DoThreadedWork() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Misc\QueuedThreadPoolWrapper.h:128]
UnrealEditor_Core!<lambda_2cfb882046ba83e24f4606b279dfb220>::operator()() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\Task.h:504]
UnrealEditor_Core!LowLevelTasks::TTaskDelegate<LowLevelTasks::FTask * __cdecl(bool),48>::TTaskDelegateImpl<<lambda_2cfb882046ba83e24f4606b279dfb220>,0>::CallAndMove() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\TaskDelegate.h:171]
UnrealEditor_Core!LowLevelTasks::FTask::ExecuteTask() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Async\Fundamental\Task.h:656]
UnrealEditor_Core!LowLevelTasks::FScheduler::ExecuteTask() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:184]
UnrealEditor_Core!LowLevelTasks::FScheduler::TryExecuteTaskFrom<&LowLevelTasks::TLocalQueueRegistry<1024>::TLocalQueue::DequeueGlobal,0>() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:361]
UnrealEditor_Core!LowLevelTasks::FScheduler::WorkerMain() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Async\Fundamental\Scheduler.cpp:402]
UnrealEditor_Core!UE::Core::Private::Function::TFunctionRefCaller<<lambda_0a548c7e497de3cc77a9e48080e1524f>,void __cdecl(void)>::Call() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Templates\Function.h:475]
UnrealEditor_Core!FThreadImpl::Run() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\HAL\Thread.cpp:67]
UnrealEditor_Core!FRunnableThreadWin::Run() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Windows\WindowsRunnableThread.cpp:149]
@mastercoms
Copy link
Member

I need to do a pass for thread safety on module management, thanks for getting a stack trace

@mastercoms mastercoms changed the title Error at close : "Assertion failed: Module" Fetch worker is not thread-safe Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants