Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt in IE11 / legacy browsers support for polyfills and browserslist (differential loading) #224

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 15, 2019 · 3 comments
Assignees
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc)

Comments

@thescientist13
Copy link
Member

thescientist13 commented Oct 15, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of #187 and #9 Greenwood provided support for programmatically adding Polyfills. However, the next step would be to able to make IE11 opt-in and allow for other browser configurations.

Details

  1. To start with, it would be great to make IE11 support in browserslist opt-in, to keep Polyfills Plugin as close to evergreen by default.
  2. From there, additional review of the default configuration should also be reviewed, to make sure it is doing the best work for those with or without older browsers to maintain.
  3. Review / track status of babel/preset-modules? Also this Twitter thread has some good conversations around @babel/preset-env and .browserslistrc
  4. Allow custom user babel or postcss config overrides?
  5. Make sure the website works
@thescientist13
Copy link
Member Author

IE11 also might need additional shims. This is what we have in Create Evergreen App docs.

ES5 Adapter

However, if transpiling down to ES5 and because Custom Elements v1 must be class based,
transpiling these v0 Custom Elements will break in modern browsers. This means a shim must be put in > place to wrap these Custom Elements so they will This

<!-- Add forwards compatibility for ES5 transpiled web components, e.g. for Chrome, Safari -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.0.2/custom-elements-es5-
adapter.js"></script>

@thescientist13
Copy link
Member Author

This could help from the PostCSS side of things: edgie.

@thescientist13 thescientist13 changed the title opt in IE11 / legacy browsers support for polyfills and browserslist opt in IE11 / legacy browsers support for polyfills and browserslist (differential loading) Oct 9, 2021
@thescientist13 thescientist13 modified the milestones: 1.0, Post 1.0 Oct 9, 2021
@thescientist13 thescientist13 removed this from the Post 1.0 milestone Mar 15, 2022
@thescientist13
Copy link
Member Author

I don't think IE11 is really relevant these days, and if it, we have a Babel plugin, or someone could create a esbuild plugin, etc.

@thescientist13 thescientist13 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
Development

No branches or pull requests

1 participant