Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate / support resolution of various common packages in node modules #429

Closed
1 of 5 tasks
thescientist13 opened this issue Nov 7, 2020 · 0 comments · Fixed by #465
Closed
1 of 5 tasks

validate / support resolution of various common packages in node modules #429

thescientist13 opened this issue Nov 7, 2020 · 0 comments · Fixed by #465
Assignees
@thescientist13 @hutchgrant
Labels
alpha.5 breaking CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) help wanted Extra attention is needed P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins RFC Proposal and changes to workflows, architecture, APIs, etc v0.10.0
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Nov 7, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of #355 and #418 , with the refactor the resolution of node_modules to import maps and Rollup, we need to make sure we handle a good variety of packages installable via npm / yarn. Right now it's mostly just ESM based packages being validated (lit-html / lit-element).

Details

Basically what Snowpack is doing, so we should test things like

  • moment
  • lodash
  • others?

We should make PRs to test these and fix. I suspect most of the support will come from CJS based packages.

Maybe we can / should just incorporate Snowpack? 🤔
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Nov 7, 2020
@thescientist13 thescientist13 mentioned this issue Nov 7, 2020
Closed
53 tasks
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Nov 8, 2020
@thescientist13 thescientist13 mentioned this issue Nov 12, 2020
Merged
12 tasks
@thescientist13 thescientist13 added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 4, 2020
@hutchgrant hutchgrant mentioned this issue Jan 6, 2021
Merged
@thescientist13 thescientist13 linked a pull request Jan 21, 2021 that will close this issue
issue 429 javascript module imports #465
Merged
@thescientist13 thescientist13 removed the good first issue Good for newcomers label Jan 24, 2021
@thescientist13 thescientist13 changed the title validate resolution of various common packages in node modules validate / support resolution of various common packages in node modules Jan 28, 2021
@thescientist13 thescientist13 added RFC Proposal and changes to workflows, architecture, APIs, etc Plugins Greenwood Plugins labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

@hutchgrant hutchgrant

Labels
alpha.5 breaking CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) help wanted Extra attention is needed P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins RFC Proposal and changes to workflows, architecture, APIs, etc v0.10.0
Projects
None yet
Milestone
No Bundle Feature Parity
Development

Successfully merging a pull request may close this issue.

issue 429 javascript module imports ProjectEvergreen/greenwood
2 participants
@thescientist13 @hutchgrant