Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional (SSR) rendering options through a render plugin type #709

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 31, 2021 · 0 comments · Fixed by #869 or #868
Closed
1 of 5 tasks
Assignees
Labels
alpha.0 CLI discussion tied to an ongoing discussion or meeting notes documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR v0.23.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 31, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of ongoing discovery in #576 , one the key action item needed is to be able to facilitate different rendering options so there can be an alternative to only being able to use puppeteer.

Details

As part of adding this new render plugin, puppeteer should be moved into a plugin of its own under the @greenwood namespace and become a peerDependency.

As bonus points, would be nice to see if this could only be installed as needed to avoid the issue of having to pull down an entire browser if don't even have any JS. (e.g. the npx hello world / getting started scenarios)

When #855 is added, by virtue of a user providing their own custom renderer, we should set prerender: true and use their renderer instead.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs Plugins Greenwood Plugins CLI SSR labels Aug 31, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 31, 2021
@thescientist13 thescientist13 self-assigned this Aug 31, 2021
@thescientist13 thescientist13 changed the title Add support for a additional (SSR) rendering options through a render plugin type Add support for additional (SSR) rendering options through a render plugin type Jan 11, 2022
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Jan 13, 2022
@thescientist13 thescientist13 linked a pull request Jan 17, 2022 that will close this issue
8 tasks
@thescientist13 thescientist13 added v0.23.0 discussion tied to an ongoing discussion or meeting notes alpha.0 labels Jan 25, 2022
@thescientist13 thescientist13 linked a pull request Jan 28, 2022 that will close this issue
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 CLI discussion tied to an ongoing discussion or meeting notes documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR v0.23.0
Projects
None yet
1 participant