Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add advanced test cases / improve code coverage for build related tests #76

Closed
1 of 5 tasks
thescientist13 opened this issue May 8, 2019 · 2 comments
Closed
1 of 5 tasks
Assignees
Labels
chore unit testing, maintenance, etc v0.3.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented May 8, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Continuing on from the work in #56 and some of the leftover TODOs from the #74 PR to add more test cases, for the sake of getting the re-org PR first to unblock other work.

Details

Would want to add additional test cases for:

  1. Build w/ import in a page with custom front matter
  2. Build with all custom templates (index, 404, app template, page template) and custom workspace
  3. Build config w/custom workspace and nested pages
  4. HTMLElement?
  5. Get more coverage on build.js (error handling)
    Screen Shot 2019-07-13 at 5 28 28 PM
@thescientist13 thescientist13 added good first issue Good for newcomers chore unit testing, maintenance, etc labels May 8, 2019
@thescientist13 thescientist13 changed the title improve code coverage for build / config related tests add advanced test cases / improve code coverage for build related tests May 8, 2019
@thescientist13 thescientist13 added this to the MVP milestone May 16, 2019
@thescientist13
Copy link
Member Author

Might just make one big test case, "the works" and put a bunch of custom stuff in there

  • HTMLElement header component
  • custom app and page template
  • custom 404 page
  • nested directories

@thescientist13 thescientist13 self-assigned this Jul 13, 2019
@thescientist13
Copy link
Member Author

Maybe as part of the work to create a Getting Started section for the website, maybe that would be a good "kitchen sink" use case for this ticket? I was thinking of making a repo that would show the code in its finished form from the Getting Started guide, and this would be a simple way to try and keep it under test within the Greenwood monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc v0.3.0
Projects
None yet
Development

No branches or pull requests

1 participant