-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft of style tweaks #146
Conversation
Excellent looks good. I'd like to see a |
One other suggestion, that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking really good @aholtzman !
One other suggestion, that the
<blockquote>
have some kind of background-color to really highlight the footnotes.
Maybe even italicize them ? I think the React docs do it well
Some other observations
- Even out the width of the three logo / text sections on the home page. Middle logo (Web Components) looks a little squished
- Would we want a color for sub-headings (h3) on getting started / docs pages?
- On Getting Started -> Build and Deploy, the image of the Netilfy configuration is quite large and seems to be causing a horizontal scroll bar.
www/pages/index.md
Outdated
This is the Greenwood website's home page! 🌱 | ||
|
||
Visit our [about page](/about) to learn more! | ||
Visit our <a href="/about">about page</a> to learn more! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self to review the language for the home page a little more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged master into this branch
* feat: adding block quote styling * fix: spelling mistakes/typos * fix: readme typo
Something else I notice is that the banner jumps when the logo loads into place. Maybe we should set a height so that it's not so dramatic of a jump / shift. I'll look into that. |
* home page copy clean up * fix code fence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Related Issue
related to issue #91
#91
Summary of Changes