Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft of style tweaks #146

Merged
merged 5 commits into from
Aug 14, 2019
Merged

first draft of style tweaks #146

merged 5 commits into from
Aug 14, 2019

Conversation

aholtzman
Copy link
Member

Related Issue

related to issue #91
#91

Summary of Changes

@hutchgrant
Copy link
Member

Excellent looks good.

I'd like to see a cursor:pointer on the shelf sub-navigation links other than that it's much better.

@hutchgrant
Copy link
Member

One other suggestion, that the <blockquote> have some kind of background-color to really highlight the footnotes.

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking really good @aholtzman !

One other suggestion, that the <blockquote> have some kind of background-color to really highlight the footnotes.

Maybe even italicize them ? I think the React docs do it well
Screen Shot 2019-08-11 at 5 58 24 PM

Some other observations

  • Even out the width of the three logo / text sections on the home page. Middle logo (Web Components) looks a little squished
  • Would we want a color for sub-headings (h3) on getting started / docs pages?
  • On Getting Started -> Build and Deploy, the image of the Netilfy configuration is quite large and seems to be causing a horizontal scroll bar.

This is the Greenwood website's home page! 🌱

Visit our [about page](/about) to learn more!
Visit our <a href="/about">about page</a> to learn more!
Copy link
Member

@thescientist13 thescientist13 Aug 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self to review the language for the home page a little more.

@thescientist13 thescientist13 added the website Tasks related to the projects website / documentation label Aug 11, 2019
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged master into this branch

* feat: adding block quote styling

* fix: spelling mistakes/typos

* fix: readme typo
@thescientist13
Copy link
Member

Something else I notice is that the banner jumps when the logo loads into place. Maybe we should set a height so that it's not so dramatic of a jump / shift. I'll look into that.

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thescientist13 thescientist13 merged commit 09f76db into master Aug 14, 2019
@thescientist13 thescientist13 deleted the styleDraft1 branch August 14, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants