Technical/issue 229 docker documentation for local development #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
question
|
@hutchgrant |
|
moved the discussion about test conventions to #259 |
…or-local-development
thescientist13
added
question
thescientist13
deleted the
technical/issue-229-docker-documentation-for-local-development
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #229
Summary of Changes
Question: I observed in some of our specs we have different ways to do top level
describe.describe('Build Greenwood With: ', async function() {describe('Build Greenwood With: ', () => {describe('Build Greenwood With: ', function() {Is there a "canonical" way we should do it? Seems like given our history here, having a single way or documented pattern would be useful. I can make them all the same as part of this PR if that helps.