Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Alphabet sort on JSON #302

Closed
1 task
NghiaTranUIT opened this issue Oct 16, 2019 · 1 comment
Closed
1 task

[BUG] Alphabet sort on JSON #302

NghiaTranUIT opened this issue Oct 16, 2019 · 1 comment
Assignees
@NghiaTranUIT
Labels
bug Something isn't working
Milestone
Proxyman 1.16.0 🎹

Comments

@NghiaTranUIT
Copy link
Member

🐶 Brief

Some users report that the JSON keys are sorted unexpectedly.

Screen Shot 2019-10-16 at 11 33 56

We should fix it 👍

👑 Criteria

  • Check why JSON's keys are sort and fix it
@NghiaTranUIT NghiaTranUIT self-assigned this Oct 16, 2019
@NghiaTranUIT NghiaTranUIT added the bug Something isn't working label Jan 31, 2020
@NghiaTranUIT NghiaTranUIT added this to the Proxyman 1.16.0 🎹 milestone Jan 31, 2020
@NghiaTranUIT
Copy link
Member Author

All done 🎉

It's complicated than my initial thought.

As Proxyman uses nlohmann/json as a high performance JSON parsers, but the library does not preserve the insertion order of object elements.

Use fifo_map as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NghiaTranUIT NghiaTranUIT

Labels
bug Something isn't working
Projects
None yet
Milestone
Proxyman 1.16.0 🎹
Development

No branches or pull requests
1 participant
@NghiaTranUIT