Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen's "Size Setting" is throwing an error when not null #58

Open
Visssarion opened this issue Oct 31, 2024 · 2 comments
Open

Fullscreen's "Size Setting" is throwing an error when not null #58

Visssarion opened this issue Oct 31, 2024 · 2 comments
Labels
3.2 bug Something isn't working

Comments

@Visssarion
Copy link

Versions tested on: 3.2.1, 3.2.0

Setting "Size Setting" inside of Fullscreen Setting Resource results in:

  • Error Trying to assign value of type 'int' to a variable of type 'String'. when running the scene
  • Error Trying to assign value of type 'bool' to a variable of type 'String'. when flipping the fullscreen switch
    on a line 29 of setting_display_fullscreen.gd

Minimal Reproduction Demo:
ggs-fullscreen.zip

@Visssarion
Copy link
Author

Visssarion commented Oct 31, 2024

Also, fullscreen setting uses MODE_FULLSCREEN, which causes 1px border around application. Using MODE_EXCLUSIVE_FULLSCREEN instead fixes it. (Maybe there could be an additional setting in the setting resource?)

From here:

  • This is intentional and done to ensure multiwindow interface works in fullscreen (MODE_FULLSCREEN is only intended for GUI apps like Godot editor itself, not for games).

  • For everything else, use MODE_EXCLUSIVE_FULLSCREEN (naming is bad, this mode is fully equivalent to 3.x MODE_FULLSCREEN).

  • I'm pretty sure it is the same in 4.2 (and other 4.x), but border was always black, now it's using clear color from project settings.

@PunchablePlushie
Copy link
Owner

I've changed the issues you've mentioned. Everything should be fine in the latest push to the 3.2 branch.

@PunchablePlushie PunchablePlushie added bug Something isn't working 3.2 labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants