Make get_or_create func placeholder return (model, bool) tuple #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
suggested changes
Apr 16, 2018
| from django.core.exceptions import MultipleObjectsReturned \ | ||
| as MultipleObjectsReturnedException | ||
|
|
||
|
|
||
| def __noop_get_or_create(self, *args, **kwargs): | ||
| return (Model(), bool(random.randint(0, 1))) |
There was a problem hiding this comment.
Why use random ? Why not return just True or False ?
There was a problem hiding this comment.
This implementation is closer to the original one, which may return either True or False and that makes it more error-proof if in the future pylint gets smart enough to run checks based on exact return values of functions.
There was a problem hiding this comment.
Fair enough. I still need a reproducer/test though.
|
@femdom can you post the original error being produced ? For some reason I was not able to reproduce. What pylint_django version do you have ? |
|
@atodorov I've faced the same issue: produces I use pylint v1.9.1 and pylint-django v0.11.1 |
atodorov
added a commit
that referenced
this pull request
Aug 2, 2018
the issue is not reproducible after the upgrade to pylint 2.0 where I deleted most of the transformations, including the offending one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, code like
raises pylint error.