Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist the coverage command in tox.ini to avoid some warnings. #216

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

aerostitch
Copy link
Contributor

This change gets rid of the following warning message in the travis builds for py{36}-django{111,20,-master} and py{35,36,37}-django21:

py37-django21 runtests: commands[0] | coverage run pylint_django/tests/test_func.py -v
WARNING: test command found but not installed in testenv
  cmd: /home/travis/virtualenv/python3.7-dev/bin/coverage
  env: /home/travis/build/PyCQA/pylint-django/.tox/py37-django21

It's just for cleanup purposes.

Thanks,
Joseph

@coveralls
Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

3 similar comments
@coveralls
Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 561

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 559: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerostitch can you rebase so I can merge cleanly.

I tried resolving the conflicts via GitHub's UI and it made another commit which I don't like.

@aerostitch
Copy link
Contributor Author

Thanks, I'll have a look asap.

@aerostitch
Copy link
Contributor Author

PR updated @atodorov . Note that if you have additional merge commits you can use the "Squash and merge" option when merging that squashes the commits together and adds the PR number in parenthesis at the end if the commit message (which... me likey! 😆 ).

@atodorov atodorov merged commit 1bc6e6c into pylint-dev:master Jan 2, 2019
@aerostitch aerostitch deleted the tox_warnings branch January 2, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants