Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to twine in tox.ini as recommended to check the rst doc. #217

Merged
merged 2 commits into from
Jan 2, 2019

Conversation

aerostitch
Copy link
Contributor

When running the readme and sanity targets you can see the following message:

readme runtests: commands[0] | python setup.py check --restructuredtext --strict
running check
warning: Check: This command has been deprecated. Use `twine check` instead: https://packaging.python.org/guides/making-a-pypi-friendly-readme#validating-restructuredtext-markup
The project's long description is valid RST.

This PR switches the check to twine as recommended.

@aerostitch aerostitch changed the title Switch to twine as recommended to check the rst doc. Switch to twine in tox.ini as recommended to check the rst doc. Jan 2, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 558

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.697%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 613
Relevant Lines: 699

💛 - Coveralls

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, generally looks good and I'm all for using the latest tools.

However I get the following message from Travis:

/home/travis/build/PyCQA/pylint-django/.tox/readme/lib/python3.6/site-packages/readme_renderer/markdown.py:38: UserWarning: Markdown renderers are not available. Install 'readme_render[md]' to enable Markdown rendering.

Also I tried twine check locally (on another project though) and it complained about the same missing pieces.

Also the package name in the message is wrong and the correct one is readme-renderer[md]

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch my previous comment. I just realized we use rst here and readme-renderer gets installed as dependency to twine.

@atodorov atodorov merged commit fe96112 into pylint-dev:master Jan 2, 2019
@aerostitch aerostitch deleted the twine branch January 2, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants