-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to twine in tox.ini as recommended to check the rst doc. #217
Conversation
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, generally looks good and I'm all for using the latest tools.
However I get the following message from Travis:
/home/travis/build/PyCQA/pylint-django/.tox/readme/lib/python3.6/site-packages/readme_renderer/markdown.py:38: UserWarning: Markdown renderers are not available. Install 'readme_render[md]' to enable Markdown rendering.
Also I tried twine check
locally (on another project though) and it complained about the same missing pieces.
Also the package name in the message is wrong and the correct one is readme-renderer[md]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scratch my previous comment. I just realized we use rst here and readme-renderer gets installed as dependency to twine.
When running the readme and sanity targets you can see the following message:
This PR switches the check to twine as recommended.